Skip to content

Commit 6e76739

Browse files
authored
Implement one-argument cov2cor!
By adding a default value for `xsd`.
1 parent 9addbb8 commit 6e76739

File tree

1 file changed

+2
-2
lines changed

1 file changed

+2
-2
lines changed

src/Statistics.jl

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -639,7 +639,7 @@ clampcor(x) = x
639639

640640
# cov2cor!
641641

642-
function cov2cor!(C::AbstractMatrix{T}, xsd::AbstractArray) where T
642+
function cov2cor!(C::AbstractMatrix{T}, xsd::AbstractArray=sqrt.(view(C, diagind(C)))) where T
643643
require_one_based_indexing(C, xsd)
644644
nx = length(xsd)
645645
size(C) == (nx, nx) || throw(DimensionMismatch("inconsistent dimensions"))
@@ -695,7 +695,7 @@ corzm(x::AbstractVector{T}) where {T} =
695695
T === Missing ? missing : one(float(nonmissingtype(T)))
696696
function corzm(x::AbstractMatrix, vardim::Int=1)
697697
c = unscaled_covzm(x, vardim)
698-
return cov2cor!(c, collect(sqrt(c[i,i]) for i in 1:min(size(c)...)))
698+
return cov2cor!(c)
699699
end
700700
corzm(x::AbstractVector, y::AbstractMatrix, vardim::Int=1) =
701701
cov2cor!(unscaled_covzm(x, y, vardim), sqrt(sum(abs2, x)), sqrt!(sum(abs2, y, dims=vardim)))

0 commit comments

Comments
 (0)