Skip to content

Commit 4e25f43

Browse files
authored
Fix a mistake in the docstring of sem (#917)
* Fix a mistake in the docstring of `sem` * Pass the Codecov token as an input (instead of an environment variable) * Codecov: set `fail_ci_if_error` to `false` iff the PR is from a fork * Whitespace
1 parent be809a8 commit 4e25f43

File tree

2 files changed

+16
-4
lines changed

2 files changed

+16
-4
lines changed

.github/workflows/ci.yml

Lines changed: 15 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -38,9 +38,21 @@ jobs:
3838
- uses: codecov/codecov-action@v4
3939
with:
4040
file: lcov.info
41-
fail_ci_if_error: true
42-
env:
43-
CODECOV_TOKEN: ${{ secrets.CODECOV_TOKEN }}
41+
# This is a public repo.
42+
# We are using v4 of the codecov-action.
43+
# If the PR is from a fork, then Codecov allows us to use
44+
# tokenless Codecov uploads.
45+
# If the PR is not from a fork, then Codecov does not allow
46+
# us to use tokenless Codecov uploads, and thus we must use
47+
# the token.
48+
# Tokenless Codcov uploads are prone to random failures,
49+
# due to Codecov's servers hitting GitHub rate limits.
50+
# Therefore:
51+
# 1. If this CI run is not a PR run, we set `fail_ci_if_error` to `true`.
52+
# 2. If this CI run is a PR run and the PR is not from a fork, we set `fail_ci_if_error` to `true`.
53+
# 3. If this CI run is a PR run and the PR is from a fork, we set `fail_ci_if_error` to `false`.
54+
fail_ci_if_error: ${{ (github.event_name != 'pull_request') || (github.repository == github.event.pull_request.head.repo.full_name) }}
55+
token: ${{ secrets.CODECOV_TOKEN }}
4456
docs:
4557
permissions:
4658
contents: write

src/scalarstats.jl

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -431,7 +431,7 @@ Return the standard error of the mean for a collection `x`.
431431
A pre-computed `mean` may be provided.
432432
433433
When not using weights, this is the (sample) standard deviation
434-
divided by the sample size. If weights are used, the
434+
divided by the square root of the sample size. If weights are used, the
435435
variance of the sample mean is calculated as follows:
436436
437437
* `AnalyticWeights`: Not implemented.

0 commit comments

Comments
 (0)