Apply suggestions from code review

Implement assorted suggestions from code review

Co-authored-by: David Widmann <[email protected]>
Co-authored-by: Moritz Schauer <[email protected]>

Author: 3 people

src/signalcorr.jl

@@ -108,16 +108,16 @@ The output is not normalized. See [`autocor`](@ref) for a function with normaliz
 """
 function autocov(x::AbstractVector, lags::AbstractVector{<:Integer}; demean::Bool=true)
     out = Vector{float(eltype(x))}(undef, length(lags))
-    autocov!(out, x, lags; demean)
+    autocov!(out, x, lags; demean=demean)
 end
 
 function autocov(x::AbstractMatrix, lags::AbstractVector{<:Integer}; demean::Bool=true)
     out = Matrix{float(eltype(x))}(undef, length(lags), size(x,2))
-    autocov!(out, x, lags; demean)
+    autocov!(out, x, lags; demean=demean)
 end
 
 autocov(x::AbstractVecOrMat; demean::Bool=true) =
-    autocov(x, default_autolags(size(x,1)); demean)
+    autocov(x, default_autolags(size(x,1)); demean=demean)
 
 ## autocor
 
@@ -155,7 +155,7 @@ function autocor!(
     T = typeof(zero(eltype(x))/1)
     z = Vector{T}(undef, size(x, 1))
     for n in 1:size(x, 2)
-        autocor!(view(r, :, n), view(x, :, n), lags, z; demean)
+        autocor!(view(r, :, n), view(x, :, n), lags, z; demean=demean)
     end
     return r
 end
@@ -180,16 +180,16 @@ autocorrelation is 1. See [`autocov`](@ref) for the unnormalized form.
 """
 function autocor(x::AbstractVector, lags::AbstractVector{<:Integer}; demean::Bool=true)
     out = Vector{float(eltype(x))}(undef, length(lags))
-    autocor!(out, x, lags; demean)
+    autocor!(out, x, lags; demean=demean)
 end
 
 function autocor(x::AbstractMatrix, lags::AbstractVector{<:Integer}; demean::Bool=true)
     out = Matrix{float(eltype(x))}(undef, length(lags), size(x,2))
-    autocor!(out, x, lags; demean)
+    autocor!(out, x, lags; demean=demean)
 end
 
 autocor(x::AbstractVecOrMat; demean::Bool=true) =
-    autocor(x, default_autolags(size(x,1)); demean)
+    autocor(x, default_autolags(size(x,1)); demean=demean)
 
 
 #######################################

src/toeplitzsolvers.jl

@@ -18,7 +18,9 @@ function durbin!(r::AbstractVector{T}, p::AbstractVector{T}, y::AbstractVector{T
             y[j] += α*conj(y[k-j+1])
             y[k-j+1] += α*conj(tmp)
         end
-        if isodd(k) y[div(k,2)+1] += α*conj(y[div(k,2)+1]) end
+        if isodd(k)
+            y[div(k,2)+1] += α*conj(y[div(k,2)+1]) 
+        end
         y[k+1] = α
         p[k+1] = α
     end

test/signalcorr.jl

@@ -132,7 +132,7 @@ function toeplitz(v::AbstractVector{T}) where T
     N=length(v)
     A = zeros(T, N - 1, N - 1)
     for n in 1:N-1
-        A[n, n + 1:end] = conj(v[2:N-n])
+        A[n, n+1:end] = conj(v[2:N-n])
         A[n, 1:n] = reverse(v[1:n])
     end
     return A