Skip to content

Commit 9d6807b

Browse files
devmotionnalimilan
andauthored
Apply suggestions from code review
Co-authored-by: Milan Bouchet-Valat <[email protected]>
1 parent 78636f1 commit 9d6807b

File tree

1 file changed

+2
-6
lines changed

1 file changed

+2
-6
lines changed

src/scalarstats.jl

Lines changed: 2 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -604,9 +604,7 @@ function crossentropy(p::AbstractArray{<:Real}, q::AbstractArray{<:Real})
604604

605605
# use pairwise summation (https://github.com/JuliaLang/julia/pull/31020)
606606
broadcasted = Broadcast.broadcasted(xlogy, vec(p), vec(q))
607-
result = - sum(Broadcast.instantiate(broadcasted))
608-
609-
return result
607+
return - sum(Broadcast.instantiate(broadcasted))
610608
end
611609

612610
crossentropy(p::AbstractArray{<:Real}, q::AbstractArray{<:Real}, b::Real) =
@@ -642,9 +640,7 @@ function kldivergence(p::AbstractArray{<:Real}, q::AbstractArray{<:Real})
642640
piqi = iszero(pi) && iszero(qi) ? zero(pi / qi) : pi / qi
643641
return xlogy(pi, piqi)
644642
end
645-
result = sum(Broadcast.instantiate(broadcasted))
646-
647-
return result
643+
return sum(Broadcast.instantiate(broadcasted))
648644
end
649645

650646
kldivergence(p::AbstractArray{<:Real}, q::AbstractArray{<:Real}, b::Real) =

0 commit comments

Comments
 (0)