Fix transformation fit call with default variables (#595)

Author: wildart

src/transformations.jl

@@ -108,6 +108,10 @@ julia> StatsBase.transform(dt, X)
 """
 function fit(::Type{ZScoreTransform}, X::AbstractMatrix{<:Real};
              dims::Union{Integer,Nothing}=nothing, center::Bool=true, scale::Bool=true)
+    if dims === nothing
+        Base.depwarn("fit(t, x) is deprecated: use fit(t, x, dims=2) instead", :fit)
+        dims = 2
+    end
     if dims == 1
         n, l = size(X)
         n >= 2 || error("X must contain at least two rows.")
@@ -116,9 +120,6 @@ function fit(::Type{ZScoreTransform}, X::AbstractMatrix{<:Real};
         l, n = size(X)
         n >= 2 || error("X must contain at least two columns.")
         m, s = mean_and_std(X, 2)
-    elseif dims === nothing
-        Base.depwarn("fit(t, x) is deprecated: use fit(t, x, dims=2) instead", :fit)
-        m, s = mean_and_std(X, 2)
     else
         throw(DomainError(dims, "fit only accept dims to be 1 or 2."))
     end
@@ -128,10 +129,8 @@ function fit(::Type{ZScoreTransform}, X::AbstractMatrix{<:Real};
 end
 
 function fit(::Type{ZScoreTransform}, X::AbstractVector{<:Real};
-             dims::Union{Integer,Nothing}=nothing, center::Bool=true, scale::Bool=true)
-    if dims == nothing
-        Base.depwarn("fit(t, x) is deprecated: use fit(t, x, dims=2) instead", :fit)
-    elseif dims != 1
+             dims::Integer=1, center::Bool=true, scale::Bool=true)
+    if dims != 1
         throw(DomainError(dims, "fit only accepts dims=1 over a vector. Try fit(t, x, dims=1)."))
     end
 
@@ -267,13 +266,14 @@ julia> StatsBase.transform(dt, X)
 """
 function fit(::Type{UnitRangeTransform}, X::AbstractMatrix{<:Real};
              dims::Union{Integer,Nothing}=nothing, unit::Bool=true)
+    if dims === nothing
+        Base.depwarn("fit(t, x) is deprecated: use fit(t, x, dims=2) instead", :fit)
+        dims = 2
+    end
     if dims == 1
         l, tmin, tmax = _compute_extrema(X)
     elseif dims == 2
         l, tmin, tmax = _compute_extrema(X')
-    elseif dims == nothing
-        Base.depwarn("fit(t, x) is deprecated: use fit(t, x, dims=2) instead", :fit)
-        l, tmin, tmax = _compute_extrema(X')
     else
         throw(DomainError(dims, "fit only accept dims to be 1 or 2."))
     end
@@ -301,7 +301,7 @@ function _compute_extrema(X::AbstractMatrix{<:Real})
 end
 
 function fit(::Type{UnitRangeTransform}, X::AbstractVector{<:Real};
-             dims::Union{Integer,Nothing}=nothing, unit::Bool=true)
+             dims::Integer=1, unit::Bool=true)
     if dims != 1
         throw(DomainError(dims, "fit only accept dims=1 over a vector. Try fit(t, x, dims=1)."))
     end