Skip to content

Conversation

@andreasnoack
Copy link
Member

The output is decorated so it shouldn't overload the two argument show method.

Also, have struct definition and show methods next to eachother in the source file.

@nalimilan
Copy link
Member

Can you confirm you just changed the signature and that other changes just move the code without modifying it?

@andreasnoack
Copy link
Member Author

Can you confirm you just changed the signature and that other changes just move the code without modifying it?

Actually, I made a single modification. I made the struct immutable. I think the struct migh predate immutable and I doubt you'd ever modify the fields of a Coeftable. Except for that, I just moved code around to have the definitions for the struct next to the struct definition.

Copy link
Member

@devmotion devmotion left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

I wonder if a custom show method with a single-line representation should be added?

@andreasnoack
Copy link
Member Author

I wonder if a custom show method with a single-line representation should be added?

I think it is hard to do better than the default one.

@nalimilan
Copy link
Member

Maybe it would be safer to make a separate PR that makes the struct immutable, and merge it before the next breaking release?

The output is decorated so it shouldn't overload the two argument
show method.

Also, have struct definition and show methods next to eachother in the
source file.
@andreasnoack
Copy link
Member Author

Fair point. I've factored that change out, so the only change is now the show method signature.

@andreasnoack andreasnoack merged commit 24c21a9 into master Dec 30, 2025
28 of 34 checks passed
@andreasnoack andreasnoack deleted the an/showcoeftable branch December 30, 2025 21:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants