-
Notifications
You must be signed in to change notification settings - Fork 197
Adjust show method signature for CoefTable to include MIME"text/plain" #986
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Can you confirm you just changed the signature and that other changes just move the code without modifying it? |
Actually, I made a single modification. I made the struct immutable. I think the struct migh predate |
devmotion
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
I wonder if a custom show method with a single-line representation should be added?
I think it is hard to do better than the default one. |
|
Maybe it would be safer to make a separate PR that makes the struct immutable, and merge it before the next breaking release? |
The output is decorated so it shouldn't overload the two argument show method. Also, have struct definition and show methods next to eachother in the source file.
734f68d to
e829c7e
Compare
|
Fair point. I've factored that change out, so the only change is now the show method signature. |
The output is decorated so it shouldn't overload the two argument show method.
Also, have struct definition and show methods next to eachother in the source file.