fix boolean-as-categorical support #327
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
palday
commented
Aug 20, 2025
ararslan
reviewed
Aug 20, 2025
| function StatsAPI.coefnames(C::AbstractContrasts, levels::AbstractVector{Bool}, baseind::Integer) | ||
| not_base = [1:(baseind-1); (baseind+1):length(levels)] | ||
| # broadcasted DataAPI.unwrap converts Vector{Bool} to BitVector | ||
| convert(Vector{Bool}, DataAPI.unwrap.(levels[not_base])) |
Member
There was a problem hiding this comment.
I wonder how this compares in terms of performance to something like
Bool[DataAPI.unwrap(level) for (i, level) in pairs(level) if i != baseind]or perhaps
Bool[DataAPI.unwrap(@inbounds levels[i])
for i in Iterators.flatten((firstindex(levels):(baseind - 1),
(baseind + 1):lastindex(levels)))]luv 2 micro-optimize
Member
Author
There was a problem hiding this comment.
if this is your performance bottleneck ... 😂
Co-authored-by: Alex Arslan <[email protected]>
ararslan
approved these changes
Aug 20, 2025
|
|
||
| # We need an explicit method for `AbstractVector{Bool}` to avoid an ambiguity | ||
| StatsAPI.coefnames(C::HypothesisCoding, levels::AbstractVector{Bool}, baseind::Int) = | ||
| something(C.labels, DataAPI.unwrap.(levels[1:length(levels) .!= baseind])) |
Member
There was a problem hiding this comment.
I wonder whether it's worth using invoke to avoid duplicating the method body?
Suggested change
| something(C.labels, DataAPI.unwrap.(levels[1:length(levels) .!= baseind])) | |
| invoke(coefnames, Tuple{HypothesisCoding,AbstractVector,Int}, C, levels, baseind) |
Probably doesn't really matter.
Member
Author
There was a problem hiding this comment.
Hmmm, I'll consider that next time, going with the "no change" lazy and fast option for now 😂
Member
|
Hmm, is the nightly CI failure related? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #326