-
Notifications
You must be signed in to change notification settings - Fork 34
Update to [email protected] #333
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
261c589 to
5651eb3
Compare
|
@devmotion have you seen any discussion of the new behavior for reduction of tuples. In 1.12, it gives julia> reduce(vcat, (1,))
1and in 1.13-alpha, I'm getting julia> reduce(vcat, (1,))
1-element Vector{Int64}:
1This change is the cause of the failure here. It makes the change in #334 redundant, but I was surprised to see this difference here. |
|
I can't check right now but I assume it's not a tuple-specific thing but a general change for 1-element collections: JuliaLang/julia#58490 |
|
Just arrived at the same conclusion. So we'll get the behavior of #334 automatically with 1.13. |
Co-authored-by: Milan Bouchet-Valat <[email protected]>
| @@ -1,5 +1,5 @@ | |||
| @testset "Model matrix" begin | |||
|
|
|||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Different line endings? Are these changes intentional?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's white space
Supersedes #331