Skip to content

Conversation

@andreasnoack
Copy link
Member

Supersedes #331

@andreasnoack
Copy link
Member Author

@devmotion have you seen any discussion of the new behavior for reduction of tuples. In 1.12, it gives

julia> reduce(vcat, (1,))
1

and in 1.13-alpha, I'm getting

julia> reduce(vcat, (1,))
1-element Vector{Int64}:
 1

This change is the cause of the failure here. It makes the change in #334 redundant, but I was surprised to see this difference here.

@devmotion
Copy link
Member

I can't check right now but I assume it's not a tuple-specific thing but a general change for 1-element collections: JuliaLang/julia#58490

@andreasnoack
Copy link
Member Author

Just arrived at the same conclusion. So we'll get the behavior of #334 automatically with 1.13.

@@ -1,5 +1,5 @@
@testset "Model matrix" begin

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Different line endings? Are these changes intentional?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's white space

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants