Skip to content

Commit a313ac9

Browse files
committed
Merge pull request #64 from leclere/upd-unit-tests
Improve coverage of unit-testing
2 parents acf696a + b61bda1 commit a313ac9

File tree

7 files changed

+40
-473
lines changed

7 files changed

+40
-473
lines changed

examples/dam.jl

Lines changed: 3 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -123,7 +123,7 @@ Return a Vector{NoiseLaw}"""
123123
function generate_probability_laws()
124124
aleas = build_scenarios(N_SCENARIOS, build_aleas())
125125

126-
laws = Vector{NoiseLaw}(N_STAGES)
126+
laws = Vector{NoiseLaw}(N_STAGES-1)
127127

128128
# uniform probabilities:
129129
proba = 1/N_SCENARIOS*ones(N_SCENARIOS)
@@ -160,13 +160,11 @@ end
160160

161161

162162
"""Solve the problem."""
163-
function solve_dams(display=false)
163+
function solve_dams(display=0)
164164
model, params = init_problem()
165165

166166
V, pbs = solve_SDDP(model, params, display)
167-
aleas = simulate_scenarios(model.noises ,(model.stageNumber-1,
168-
params.forwardPassNumber , model.dimNoises))
169-
params.forwardPassNumber = 1
167+
aleas = simulate_scenarios(model.noises, params.forwardPassNumber)
170168

171169
costs, stocks = forward_simulations(model, params, V, pbs, aleas)
172170

examples/damsvalley.jl

Lines changed: 4 additions & 13 deletions
Original file line numberDiff line numberDiff line change
@@ -126,7 +126,7 @@ Return a Vector{NoiseLaw}"""
126126
function generate_probability_laws()
127127
aleas = build_scenarios(N_SCENARIOS, build_aleas())
128128

129-
laws = Vector{NoiseLaw}(N_STAGES)
129+
laws = Vector{NoiseLaw}(N_STAGES-1)
130130

131131
# uniform probabilities:
132132
proba = 1/N_SCENARIOS*ones(N_SCENARIOS)
@@ -165,21 +165,12 @@ end
165165

166166

167167
"""Solve the problem."""
168-
function solve_dams(display=false)
169-
168+
function solve_dams(display=0)
170169
model, params = init_problem()
171170

172171
V, pbs = solve_SDDP(model, params, display)
173-
174-
aleas = simulate_scenarios(model.noises,
175-
(model.stageNumber-1,
176-
params.forwardPassNumber,
177-
model.dimNoises))
178-
179-
params.forwardPassNumber = 1
180-
181-
costs, stocks = forward_simulations(model, params, V, pbs, aleas)
182-
172+
aleas = simulate_scenarios(model.noises, params.forwardPassNumber)
173+
costs, stocks, controls = forward_simulations(model, params, V, pbs, aleas)
183174

184175
println("SDDP cost: ", costs)
185176
return stocks, V, controls

0 commit comments

Comments
 (0)