Skip to content

Commit 0910be3

Browse files
committed
Use -1 % Csize_t instead of reinterpret(Csize_t, -1)
This is because reinterpret(Csize_t, -1) may give an error if -1 literal is type Int32 instead of Int64 (as is true on 32-bit platforms), as reinterpret requires the sizes of scalar bittypes to be the same.
1 parent ab97927 commit 0910be3

File tree

1 file changed

+2
-2
lines changed

1 file changed

+2
-2
lines changed

src/iconv.jl

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -79,7 +79,7 @@ function iconv!(cd::Ptr{Void}, inbuf::Vector{UInt8}, outbuf::Vector{UInt8},
7979
(Ptr{Void}, Ptr{Ptr{UInt8}}, Ref{Csize_t}, Ptr{Ptr{UInt8}}, Ref{Csize_t}),
8080
cd, inbufptr, inbytesleft, outbufptr, outbytesleft)
8181

82-
if ret == reinterpret(Csize_t, -1)
82+
if ret == -1 % Csize_t
8383
err = errno()
8484

8585
# Should never happen unless a very small buffer is used
@@ -111,7 +111,7 @@ function iconv_reset!(s::Union{StringEncoder, StringDecoder})
111111
(Ptr{Void}, Ptr{Ptr{UInt8}}, Ref{Csize_t}, Ptr{Ptr{UInt8}}, Ref{Csize_t}),
112112
s.cd, C_NULL, C_NULL, s.outbufptr, s.outbytesleft)
113113

114-
if ret == reinterpret(Csize_t, -1)
114+
if ret == -1 % Csize_t
115115
err = errno()
116116
if err == EINVAL
117117
error("iconv error: incomplete byte sequence at end of input")

0 commit comments

Comments
 (0)