Skip to content

Commit f0ecb57

Browse files
sambitdashnalimilan
authored andcommitted
Add libc-bin to library aliases (#19)
Fixes library dependency on Ubuntu 17.04.
1 parent 2631c9a commit f0ecb57

File tree

2 files changed

+5
-1
lines changed

2 files changed

+5
-1
lines changed

README.md

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -149,3 +149,7 @@ julia> readstring(s) # Decoding happens automatically here
149149
Do not forget to call `close` on `StringEncoder` and `StringDecoder` objects to finish the encoding process. For `StringEncoder`, this function calls `flush`, which writes any characters still in the buffer, and possibly some control sequences (for stateful encodings). For both `StringEncoder` and `StringDecoder`, `close` checks that there are no incomplete sequences left in the input stream, and raise an `IncompleteSequenceError` if that's the case. It will also free iconv resources immediately, instead of waiting for garbage collection.
150150

151151
Conversion currently raises an error if an invalid byte sequence is encountered in the input, or if some characters cannot be represented in the target enconding. It is not yet possible to ignore such characters or to replace them with a placeholder.
152+
153+
## Notes on Installation on Linux OS
154+
155+
Most Linux distributions provide `iconv` functionalities as part of the base operating system library `glibc`. In normal circumstances, no additional installation of `libiconv` should be required. If you observe such a behavior on your operating system, file an issue with OS details.

deps/build.jl

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -31,7 +31,7 @@ function validate_iconv(n, h)
3131
return ret == -1 % Csize_t && Libc.errno() == Libc.EILSEQ
3232
end
3333

34-
libiconv = library_dependency("libiconv", aliases = ["libc", "iconv"],
34+
libiconv = library_dependency("libiconv", aliases = ["libc", "libc-bin", "iconv"],
3535
validate = validate_iconv)
3636

3737
if is_windows()

0 commit comments

Comments
 (0)