Fix name conflict with Nemo.integrate #45
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Change `using Nemo` to `import Nemo` in test files to avoid exporting Nemo's `integrate` function which conflicts with SymbolicIntegration.integrate This resolves test failures in CompatHelper PRs JuliaSymbolics#16 and JuliaSymbolics#17 where the ambiguous `integrate` function caused UndefVarError. Affected files: - test/methods/risch/test_complex_fields.jl - test/methods/risch/test_bronstein_examples.jl - test/methods/risch/test_algorithm_internals.jl - test/methods/risch/bronstein_examples.jl 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <[email protected]>
|
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #45 +/- ##
=======================================
Coverage ? 22.63%
=======================================
Files ? 20
Lines ? 4131
Branches ? 0
=======================================
Hits ? 935
Misses ? 3196
Partials ? 0 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
Test files using both
using SymbolicIntegrationandusing Nemocause name conflicts because both packages export anintegratefunction. This causesUndefVarErrorin tests, preventing CompatHelper PRs #16 and #17 from passing.Solution
Changed
using Nemotoimport Nemoin test files to avoid exporting Nemo's symbols while still allowing access to Nemo functions via qualified names (e.g.,Nemo.QQ).Testing
Files Changed
test/methods/risch/test_complex_fields.jltest/methods/risch/test_bronstein_examples.jltest/methods/risch/test_algorithm_internals.jltest/methods/risch/bronstein_examples.jlRelated Issues
Fixes test failures in:
🤖 Generated with Claude Code
Co-Authored-By: Claude [email protected]