Fix Vararg syntax error for Julia 1.12 compatibility #47
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Replace @variables ∫(.., ..) with SymbolicUtils.@syms ∫(::Any, ::Any)::Real The original syntax @variables ∫(.., ..) caused a TypeError in Julia 1.12: "TypeError: in Tuple, in non-final parameter, expected Type, got Vararg" This was preventing package registration for v3.2.0. The new syntax uses SymbolicUtils.@syms which is compatible with Julia 1.12 and correctly defines the unevaluated integral symbol as a function taking two arguments. Fixes package loading error at src/methods/risch/frontend.jl:728 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <[email protected]>
|
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #47 +/- ##
=======================================
Coverage 22.63% 22.63%
=======================================
Files 20 20
Lines 4131 4131
=======================================
Hits 935 935
Misses 3196 3196 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fixes package loading error that prevented v3.2.0 registration by replacing invalid Vararg syntax with SymbolicUtils.@syms.
Problem
The package registration for v3.2.0 failed with:
This occurred at
src/methods/risch/frontend.jl:728where the code used:This syntax is incompatible with Julia 1.12's type system restrictions on Vararg placement.
Solution
Changed line 728 to:
This properly declares the unevaluated integral symbol as a function taking exactly two arguments (the integrand and the variable), which matches how it's used throughout the codebase (lines 806, 823, 828).
Testing
Related Issues
This fixes the package registration failure for v3.2.0.
🤖 Generated with Claude Code