Merge pull request #695 from AayushSabharwal/as/toggle-hashconsing

feat: add toggle for hashconsing

Author: ChrisRackauckas

src/types.jl

@@ -21,6 +21,7 @@ const EMPTY_HASH = RefValue(UInt(0))
 const NOT_SORTED = RefValue(false)
 const EMPTY_DICT = sdict()
 const EMPTY_DICT_T = typeof(EMPTY_DICT)
+const ENABLE_HASHCONSING = Ref(true)
 
 @compactify show_methods=false begin
     @abstract mutable struct BasicSymbolic{T} <: Symbolic{T}
@@ -507,6 +508,9 @@ Custom functions `hash2` and `isequal_with_metadata` are used instead of `Base.h
 original behavior of those functions.
 """
 function BasicSymbolic(s::BasicSymbolic)::BasicSymbolic
+    if !ENABLE_HASHCONSING[]
+        return s
+    end
     h = hash2(s)
     t = get!(wvd, h, s)
     if t === s || isequal_with_metadata(t, s)

test/hash_consing.jl

@@ -128,3 +128,12 @@ end
     @test !SymbolicUtils.isequal_with_metadata(a, aa)
     @test !SymbolicUtils.isequal_with_metadata(2a, 2aa)
 end
+
+@testset "Hashconsing can be toggled" begin
+    SymbolicUtils.ENABLE_HASHCONSING[] = false
+    name = gensym(:x)
+    x1 = only(@eval @syms $name)
+    x2 = only(@eval @syms $name)
+    @test x1 !== x2
+    SymbolicUtils.ENABLE_HASHCONSING[] = true
+end