Merge pull request #409 from gronniger/add_generic_ndims_broadcast

ndims() and broadcast() definitions for generic symbolic types

Author: shashi

src/methods.jl

@@ -155,4 +155,6 @@ Base.literal_pow(::typeof(^), x::Symbolic{<:Number}, ::Val{p}) where {p} = Base.
 # Array-like operations
 Base.size(x::Symbolic{<:Number}) = ()
 Base.length(x::Symbolic{<:Number}) = 1
-Base.ndims(x::Symbolic{<:Number}) = 0
+Base.ndims(x::Symbolic{T}) where {T} = Base.ndims(T)
+Base.ndims(::Type{<:Symbolic{T}}) where {T} = Base.ndims(T)
+Base.broadcastable(x::Symbolic{T}) where {T<:Number} = Ref(x)

test/basics.jl

@@ -1,4 +1,4 @@
-using SymbolicUtils: Sym, FnType, Term, Add, Mul, Pow, symtype, operation, arguments
+using SymbolicUtils: Symbolic, Sym, FnType, Term, Add, Mul, Pow, symtype, operation, arguments
 using SymbolicUtils
 using IfElse: ifelse
 using Test
@@ -134,6 +134,16 @@ end
     @eqtest x // a == x / a
 end
 
+@testset "array-like operations" begin
+    abstract type SquareDummy end
+    Base.:*(a::Symbolic{SquareDummy}, b) = b^2
+    @syms s t a::SquareDummy A[1:2, 1:2]
+
+    @test isequal(ndims(A), 2)
+    @test_broken isequal(a.*[1 (s+t); t pi], [1 (s+t)^2; t^2 pi^2])
+    @test isequal(s.*[1 (s+t); t pi], [s s*(s+t); s*t s*pi])
+end
+
 @testset "err test" begin
     @syms t()
     @test_throws ErrorException t(2)