Merge pull request #715 from AayushSabharwal/as/hashconsing-number-equality

fix: ensure numbers have the same type in `isequal_with_metadata`

Author: bowenszhu

src/types.jl

@@ -406,6 +406,8 @@ function isequal_with_metadata(a::Union{AbstractArray, Tuple}, b::Union{Abstract
     return true
 end
 
+isequal_with_metadata(a::Number, b::Number) = typeof(a) == typeof(b) && isequal(a, b)
+
 Base.one( s::Symbolic) = one( symtype(s))
 Base.zero(s::Symbolic) = zero(symtype(s))
 

test/hash_consing.jl

@@ -188,3 +188,17 @@ Base.isequal(a::MySymbolic, b::MySymbolic) = isequal(a.sym, b.sym)
     @test isequal(myt, mytt)
     @test !isequal_with_metadata(myt, mytt)
 end
+
+@testset "`isequal_with_metadata` ensures numbers have the same type" begin
+    @syms x
+    tmp1 = x ^ 3.0
+    tmp2 = x ^ 3
+    @test !SymbolicUtils.isequal_with_metadata(tmp1, tmp2)
+    @test arguments(tmp1)[2] isa Float64
+    @test arguments(tmp2)[2] isa Int
+    tmp1 = 2tmp1
+    tmp2 = 2tmp2
+    @test !SymbolicUtils.isequal_with_metadata(tmp1, tmp2)
+    @test arguments(arguments(tmp1)[2])[2] isa Float64
+    @test arguments(arguments(tmp2)[2])[2] isa Int
+end