Merge pull request #798 from JuliaSymbolics/as/more-fixes

fix: fix bugs

Author: AayushSabharwal

.github/workflows/ci.yml

@@ -20,6 +20,7 @@ jobs:
       matrix:
         version:
           - 'min'
+          - '1.11' # to test inference
           - '1'
       fail-fast: false
     steps:

Project.toml

@@ -25,7 +25,7 @@ ReadOnlyArrays = "988b38a3-91fc-5605-94a2-ee2116b3bd83"
 Setfield = "efcf1570-3423-57d1-acb7-fd33fddbac46"
 SparseArrays = "2f01184e-e22b-5df5-ae63-d93ebab69eaf"
 SpecialFunctions = "276daf66-3868-5448-9aa4-cd146d93841b"
-StaticArrays = "90137ffa-7385-5640-81b9-e52037218182"
+StaticArraysCore = "1e83bf80-4336-4d27-bf5d-d5a4f845583c"
 SymbolicIndexingInterface = "2efcf032-c050-4f8e-a9bb-153293bab1f5"
 TaskLocalValues = "ed4db957-447d-4319-bfb6-7fa9ae7ecf34"
 TermInterface = "8ea1fca8-c5ef-4a55-8b96-4e9afe9c9a3c"
@@ -67,9 +67,11 @@ ReadOnlyArrays = "0.2.0"
 ReverseDiff = "1"
 RuntimeGeneratedFunctions = "0.5.13"
 Setfield = "0.7, 0.8, 1"
+SnoopCompileCore = "3.0.0"
 SparseArrays = "1"
 SpecialFunctions = "0.10, 1.0, 2"
-StaticArrays = "0.12, 1.0"
+StaticArrays = "1.0"
+StaticArraysCore = "1.4.3"
 SymbolicIndexingInterface = "0.3"
 TaskLocalValues = "0.1.2"
 TermInterface = "2.0"
@@ -88,8 +90,11 @@ ReferenceTests = "324d217c-45ce-50fc-942e-d289b448e8cf"
 ReverseDiff = "37e2e3b7-166d-5795-8a7a-e32c996b4267"
 RuntimeGeneratedFunctions = "7e49a35a-f44a-4d26-94aa-eba1b4ca6b47"
 SafeTestsets = "1bc83da4-3b8d-516f-aca4-4fe02f6d838f"
+SnoopCompile = "aa65fe97-06da-5843-b5b1-d5d13cad87d2"
+SnoopCompileCore = "e2b509da-e806-4183-be48-004708413034"
+StaticArrays = "90137ffa-7385-5640-81b9-e52037218182"
 Test = "8dfed614-e22c-5e08-85e1-65c5234f0b40"
 Zygote = "e88e6eb3-aa80-5325-afca-941959d7151f"
 
 [targets]
-test = ["BenchmarkTools", "Documenter", "LabelledArrays", "Pkg", "PkgBenchmark", "Random", "ReferenceTests", "ReverseDiff", "SafeTestsets", "Test", "Zygote", "OhMyThreads", "RuntimeGeneratedFunctions"]
+test = ["BenchmarkTools", "Documenter", "LabelledArrays", "Pkg", "PkgBenchmark", "Random", "ReferenceTests", "ReverseDiff", "SafeTestsets", "Test", "Zygote", "OhMyThreads", "RuntimeGeneratedFunctions", "StaticArrays", "SnoopCompile", "SnoopCompileCore"]

benchmark/benchmarks.jl

@@ -58,15 +58,16 @@ let r = @rule(~x => ~x), rs = RuleSet([r]),
 
     # we use `fold = false` since otherwise it dynamic dispatches to `sin`/`cos` whenever
     # both arguments in the contained addition are substituted.
-    overhead["substitute"]["a"] = @benchmarkable substitute(subs_expr, $(Dict(a=>1)); fold = false) setup=begin
+
+    overhead["substitute"]["a"] = @benchmarkable substitute(subs_expr, $(Dict(a=>1))) setup=begin
         subs_expr = (sin(a+b) + cos(b+c)) * (sin(b+c) + cos(c+a)) * (sin(c+a) + cos(a+b))
     end
 
-    overhead["substitute"]["a,b"] = @benchmarkable substitute(subs_expr, $(Dict(a=>1, b=>2)); fold = false) setup=begin
+    overhead["substitute"]["a,b"] = @benchmarkable substitute(subs_expr, $(Dict(a=>1, b=>2))) setup=begin
         subs_expr = (sin(a+b) + cos(b+c)) * (sin(b+c) + cos(c+a)) * (sin(c+a) + cos(a+b))
     end
 
-    overhead["substitute"]["a,b,c"] = @benchmarkable substitute(subs_expr, $(Dict(a=>1, b=>2, c=>3)); fold = false) setup=begin
+    overhead["substitute"]["a,b,c"] = @benchmarkable substitute(subs_expr, $(Dict(a=>1, b=>2, c=>3))) setup=begin
         subs_expr = (sin(a+b) + cos(b+c)) * (sin(b+c) + cos(c+a)) * (sin(c+a) + cos(a+b))
     end
 

docs/pages.jl

@@ -2,7 +2,8 @@ pages = Any["index.md",
             "Manual" => Any["manual/representation.md",
                             "manual/rewrite.md",
                             "manual/interface.md",
-                            "manual/codegen.md"],
+                            "manual/codegen.md",
+                            "manual/variants.md"],
             "api.md",
             "upgrade.md"
             ]

docs/src/api.md

@@ -3,22 +3,11 @@
 ## Symbols and Terms
 
 ### Creating Symbols and Terms
-```@docs
+```@docs; canonical=false
 SymbolicUtils.@syms
 SymbolicUtils.term
 ```
 
-### Inspecting Terms
-```@docs
-SymbolicUtils.issym
-SymbolicUtils.symtype
-SymbolicUtils.iscall
-SymbolicUtils.operation
-SymbolicUtils.arguments
-SymbolicUtils.sorted_arguments
-SymbolicUtils.showraw
-```
-
 ### Metadata
 ```@docs
 SymbolicUtils.hasmetadata
@@ -27,7 +16,7 @@ SymbolicUtils.setmetadata
 ```
 
 ### Type Promotion
-```@docs
+```@docs; canonical=false
 SymbolicUtils.promote_symtype
 ```