tests

Author: shashi

src/methods.jl

@@ -88,7 +88,7 @@ end
 @number_methods(Pow, term(f, a), term(f, a, b), skipbasics)
 @number_methods(Div, term(f, a), term(f, a, b), skipbasics)
 
-for f in diadic
+for f in vcat(diadic, [+, -, *, \, /, ^])
     @eval promote_symtype(::$(typeof(f)),
                    T::Type{<:Number},
                    S::Type{<:Number}) = promote_type(T, S)
@@ -112,18 +112,6 @@ for f in diadic
     end
 end
 
-for f in [+, -, *, \, /, ^]
-    @eval promote_symtype(::$(typeof(f)),
-                   T::Type{<:Number},
-                   S::Type{<:Number}) = promote_type(T, S)
-    @eval function promote_symtype(::$(typeof(f)),
-                   T::Type{<:SafeReal},
-                   S::Type{<:Number})
-        X = promote_type(Real, S)
-        X == Real ? SafeReal : X
-    end
-end
-
 promote_symtype(::typeof(rem2pi), T::Type{<:Number}, mode) = T
 Base.rem2pi(x::Symbolic{<:Number}, mode::Base.RoundingMode) = term(rem2pi, x, mode)
 

src/types.jl

@@ -698,6 +698,7 @@ function makeadd(sign, coeff, xs...)
     coeff, d
 end
 
+add_t(a::Number,b::Number) = promote_symtype(+, symtype(a), symtype(b))
 add_t(a,b) = promote_symtype(+, symtype(a), symtype(b))
 sub_t(a,b) = promote_symtype(-, symtype(a), symtype(b))
 sub_t(a) = promote_symtype(-, symtype(a))

test/basics.jl

@@ -238,7 +238,7 @@ end
 end
 
 @testset "div" begin
-    @syms x y
+    @syms x::SafeReal y::Real
     @test (2x/2y).num isa Sym
     @test (2x/3y).num.coeff == 2
     @test (2x/3y).den.coeff == 3
@@ -247,4 +247,13 @@ end
     @test (2.5x/3x).num.coeff == 2.5
     @test (2.5x/3x).den.coeff == 3
     @test (x/3x).den.coeff == 3
+
+    @syms x y
+    @test (2x/2y).num isa Sym
+    @test (2x/3y).num.coeff == 2
+    @test (2x/3y).den.coeff == 3
+    @test (2x/-3x) == -2//3
+    @test (2.5x/3x).num == 2.5
+    @test (2.5x/3x).den == 3
+    @test (x/3x) == 1//3
 end