Merge pull request #733 from AayushSabharwal/as/cse-fixes

fix: fix some issues with CSE

Author: AayushSabharwal

src/code.jl

@@ -857,7 +857,8 @@ function cse!(expr::Symbolic, state::CSEState)
         args = arguments(expr)
         cse_inside_expr(expr, op, args...) || return expr
         args = map(args) do arg
-            if arg isa Union{Tuple, AbstractArray}
+            if arg isa Union{Tuple, AbstractArray} &&
+                (_is_array_of_symbolics(arg) || _is_tuple_of_symbolics(arg))
                 if arg isa Tuple
                     new_arg = cse!(MakeTuple(arg), state)
                     sym = newsym(Tuple{symtype.(arg)...})
@@ -889,6 +890,7 @@ cse!(x::LiteralExpr, ::CSEState) = x
 
 cse!(x::CodegenPrimitive, state::CSEState) = throw(MethodError(cse!, (x, state)))
 
+cse!(x::AbstractRange, ::CSEState) = x
 function cse!(x::AbstractArray, state::CSEState)
     res = map(Base.Fix2(cse!, state), x)
     return res

test/cse.jl

@@ -220,3 +220,12 @@ end
     @test all(iszero, arr[1:3])
     @test all(iszero, arr[8:end])
 end
+
+@testset "CSE doesn't affect ranges" begin
+    @syms x::Array
+    t = term(view, x, 1:3)
+    fnexpr = Func([x], [], t)
+    fn1 = @RuntimeGeneratedFunction(toexpr(fnexpr))
+    fn2 = @RuntimeGeneratedFunction(cse(toexpr(fnexpr)))
+    @test fn1(ones(5)) == fn2(ones(5))
+end