adjoint(Symbolic{Number}) method

Author: ChristophHotter

src/methods.jl

@@ -160,37 +160,14 @@ for f in [identity, one, zero, *, +, -]
 end
 
 promote_symtype(::typeof(Base.real), T::Type{<:Number}) = Real
+Base.real(s::Symbolic{<:Number}) = islike(s, Real) ? s : term(real, s)
 promote_symtype(::typeof(Base.conj), T::Type{<:Number}) = T
+Base.conj(s::Symbolic{<:Number}) = islike(s, Real) ? s : term(conj, s)
 promote_symtype(::typeof(Base.imag), T::Type{<:Number}) = Real
-function Base.real(s::Symbolic{<:Number}) 
-    if iscall(s) 
-        f = operation(s)
-        args = map(real, arguments(s))
-        return f(args...)
-    else
-        islike(s, Real) ? s : term(real, s)
-    end
-end
-function Base.conj(s::Symbolic{<:Number}) 
-    if iscall(s) 
-        f = operation(s)
-        args = map(conj, arguments(s))
-        return f(args...)
-    else
-        islike(s, Real) ? s : term(conj, s)
-    end
-end
-function Base.imag(s::Symbolic{<:Number}) 
-    if iscall(s) 
-        f = operation(s)
-        args = map(imag, arguments(s))
-        return f(args...)
-    else
-        islike(s, Real) ? zero(symtype(s)) : term(imag, s)
-    end
-end
+Base.imag(s::Symbolic{<:Number}) = islike(s, Real) ? zero(symtype(s)) : term(imag, s)
 Base.adjoint(s::Symbolic{<:Number}) = conj(s)
 
+
 ## Booleans
 
 # binary ops that return Bool

test/basics.jl

@@ -353,15 +353,4 @@ end
         @test typeof(sin(x)) <: BasicSymbolic{LiteralReal}
     end
     @test repr(sin(x) + sin(x)) == "sin(x) + sin(x)"
-end
-
-@testset "real and complex" begin
-    @syms x y z::Real
-    @test isequal(conj(x*y*z), conj(x)*conj(y)*z)
-    @test isequal(conj(x*y*z + y), conj(x)*conj(y)*z + conj(y))
-    @test isequal(real(x*y*z + y), real(x)*real(y)*z + real(y))
-    @test isequal(imag(x*y*z + y), imag(y))
-    @test isequal(imag(x*y*z + y), imag(y))
-    @test isequal(conj(exp(1im*x)*y), conj(exp(1im*x))*conj(y))
-    @test isequal(adjoint(x*y*z), conj(x)*conj(y)*z)    
 end