Skip to content

Commit bb49dde

Browse files
shashiYingboMa
andcommitted
adjust tests for removing vararg methods
Co-authored-by: "Yingbo Ma" <[email protected]>
1 parent e274de7 commit bb49dde

File tree

3 files changed

+11
-12
lines changed

3 files changed

+11
-12
lines changed

src/methods.jl

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -115,9 +115,9 @@ for (f, Domain) in [(==) => Number, (!=) => Number,
115115
xor => Bool]
116116
@eval begin
117117
promote_symtype(::$(typeof(f)), ::Type{<:$Domain}, ::Type{<:$Domain}) = Bool
118-
(::$(typeof(f)))(a::Symbolic, b::$Domain) = term($f, a, b, type=Bool)
119-
(::$(typeof(f)))(a::Symbolic, b::Symbolic) = term($f, a, b, type=Bool)
120-
(::$(typeof(f)))(a::$Domain, b::Symbolic) = term($f, a, b, type=Bool)
118+
(::$(typeof(f)))(a::Symbolic{<:$Domain}, b::$Domain) = term($f, a, b, type=Bool)
119+
(::$(typeof(f)))(a::Symbolic{<:$Domain}, b::Symbolic{<:$Domain}) = term($f, a, b, type=Bool)
120+
(::$(typeof(f)))(a::$Domain, b::Symbolic{<:$Domain}) = term($f, a, b, type=Bool)
121121
end
122122
end
123123

test/rewrite.jl

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -37,8 +37,7 @@ end
3737
@eqtest @rule((~x*~y + ~x*~z) => ~x * (~y+~z))(a*b + a*c) == a*(b+c)
3838

3939
@eqtest @rule(+(~~x) => ~~x)(a + b) == [a,b]
40-
@eqtest @rule(+(~~x) => ~~x)(a + b + c) == [a,b,c]
41-
@eqtest @rule(+(~~x) => ~~x)(+(a, b, c)) == [a,b,c]
40+
@eqtest @rule(+(~~x) => ~~x)(term(+, a, b, c)) == [a,b,c]
4241
@eqtest @rule(+(~~x,~y, ~~x) => (~~x, ~y))(term(+,9,8,9,type=Any)) == ([9,],8)
4342
@eqtest @rule(+(~~x,~y, ~~x) => (~~x, ~y, ~~x))(term(+,9,8,9,9,8,type=Any)) == ([9,8], 9, [9,8])
4443
@eqtest @rule(+(~~x,~y,~~x) => (~~x, ~y, ~~x))(term(+,6,type=Any)) == ([], 6, [])

test/rulesets.jl

Lines changed: 7 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -10,7 +10,7 @@ using SymbolicUtils: getdepth, Rewriters
1010
rset = Rewriters.Postwalk(Rewriters.Chain([r1, r2]))
1111
@test getdepth(rset) == typemax(Int)
1212

13-
ex = 2 * (w+w+α+β)
13+
ex = 2 * term(+, w, w, α, β)
1414

1515
@eqtest rset(ex) == (((2 * w) + (2 * w)) + (2 * α)) + (2 * β)
1616
@eqtest Rewriters.Fixpoint(rset)(ex) == ((2 * (2 * w)) + (2 * α)) + (2 * β)
@@ -30,14 +30,14 @@ end
3030
@eqtest simplify(1x + 2x) == 3x
3131
@eqtest simplify(3x + 2x) == 5x
3232

33-
@eqtest simplify(a + b + (x * y) + c + 2 * (x * y) + d) == (3 * x * y) + a + b + c + d
34-
@eqtest simplify(a + b + 2 * (x * y) + c + 2 * (x * y) + d) == (4 * x * y) + a + b + c + d
33+
@eqtest simplify(a + b + (x * y) + c + 2 * (x * y) + d) == simplify((3 * x * y) + a + b + c + d)
34+
@eqtest simplify(a + b + 2 * (x * y) + c + 2 * (x * y) + d) == simplify((4 * x * y) + a + b + c + d)
3535

36-
@eqtest simplify(a * x^y * b * x^d) == (a * b * (x ^ (d + y)))
36+
@eqtest simplify(a * x^y * b * x^d) == simplify(a * b * (x ^ (d + y)))
3737

38-
@eqtest simplify(a + b + 0*c + d) == a + b + d
39-
@eqtest simplify(a * b * c^0 * d) == a * b * d
40-
@eqtest simplify(a * b * 1*c * d) == a * b * c * d
38+
@eqtest simplify(a + b + 0*c + d) == simplify(a + b + d)
39+
@eqtest simplify(a * b * c^0 * d) == simplify(a * b * d)
40+
@eqtest simplify(a * b * 1*c * d) == simplify(a * b * c * d)
4141

4242
@test simplify(Term(one, [a])) == 1
4343
@test simplify(Term(one, [b+1])) == 1

0 commit comments

Comments
 (0)