Merge pull request #1479 from AayushSabharwal/as/cache-diff

build: bump SymbolicUtils compat

Author: ChrisRackauckas

Project.toml

@@ -92,7 +92,7 @@ StaticArraysCore = "1.4"
 SymPy = "2.2"
 SymbolicIndexingInterface = "0.3.14"
 SymbolicLimits = "0.2.2"
-SymbolicUtils = "3.17"
+SymbolicUtils = "3.19"
 TermInterface = "2"
 julia = "1.10"
 

ext/SymbolicsGroebnerExt.jl

@@ -3,7 +3,7 @@ module SymbolicsGroebnerExt
 using Groebner
 const Nemo = Groebner.Nemo
 using Symbolics
-using Symbolics: Num, symtype
+using Symbolics: Num, symtype, BasicSymbolic
 import Symbolics.PrecompileTools
 
 """
@@ -68,7 +68,7 @@ julia> @variables x y;
 julia> is_groebner_basis([x^2 - y^2, x*y^2 + x, y^3 + y])
 ```
 """
-function Symbolics.is_groebner_basis(polynomials::Vector{Num}; kwargs...)
+function Symbolics.is_groebner_basis(polynomials::Vector{<:Union{Num, BasicSymbolic{<:Number}}}; kwargs...)
     polynoms, _, _ = Symbolics.symbol_to_poly(polynomials)
     Groebner.isgroebner(polynoms; kwargs...)
 end

test/extensions/groebner.jl

@@ -51,10 +51,13 @@ truebasis = [
     x5^5 - 1
 ]
 basis = expand.(groebner_basis(system))
-@test isequal(basis, truebasis)
+# monomial order can change, returning different but still valid bases
+@test_broken isequal(basis, truebasis)
+@test Symbolics.is_groebner_basis(basis)
 
 basis = expand.(groebner_basis(system, linalg=:deterministic))
-@test isequal(basis, truebasis)
+@test_broken isequal(basis, truebasis)
+@test Symbolics.is_groebner_basis(basis)
 
 N = 45671930739135174346839766056203605080877915151
 system = [
@@ -69,8 +72,9 @@ truebasis = [
     x3^3 + x3^2 * x4 + x3 * x4^2 + x4^3,
     x4^4 - N
 ]
-basis = groebner_basis(system)
-@test isequal(expand.(basis), truebasis)
+basis = expand.(groebner_basis(system))
+@test_broken isequal(expand.(basis), truebasis)
+@test Symbolics.is_groebner_basis(basis)
 
 # issues/1323
 @variables t S(t) R(t)