Error during testing

[alblaz]

Hello,
I tried to test to IdentificationToolbox.jl but I get the following error:

ERROR: LoadError: LoadError: MethodError: no method matching _getpolys(::IdentificationToolbox.PolyModel{Val{:siso},IdentificationToolbox.FullPolyOrder{Val{:mimo}},IdentificationToolbox.ARX}, ::Array{Float64,1}) Closest candidates are: _getpolys(::IdentificationToolbox.PolyModel{S,IdentificationToolbox.FullPolyOrder{S},M}, ::Array{T<:Real,1}) where {T<:Real, S, M} at C:\Users\alaz\.julia\v0.6\IdentificationToolbox\src\methods/pem.jl:86 _getpolys(::IdentificationToolbox.PolyModel{S,IdentificationToolbox.MPolyOrder,M}, ::Array{T<:Real,1}) where {T<:Real, S, M} at C:\Users\alaz\.julia\v0.6\IdentificationToolbox\src\methods/pem.jl:207

It seems that the PolyModel object passed to the method _getpolys does not have the correct signature.

[neveritt]

Hi,

I'm glad that you are trying out the toolbox. Could you please post a minimal working example that produces this error?

[alblaz]

Hi,
The working example basically would be

using IdentificationToolbox
include(joinpath(Pkg.dir("IdentificationToolbox"), "test","arx.jl"))

I did some minor changes to the src code of IdentificationToolbox.jl to make it run. Namely I refactored SystemsBase with LTISystems (which seems to be the new SystemsBase) and I removed autodiff=autodiff in 'src/types/options.jl' since it was throwing an error.

[aytekinar]

I did some minor changes to the src code of IdentificationToolbox.jl to make it run. Namely I refactored SystemsBase with LTISystems (which seems to be the new SystemsBase)

This should have been properly handled. I have created a couple of PRs for this. Thanks, Alberto, for the update! By "properly", I mean we also need to bump the julia 0.4 requirement, as it does not make any sense due to the requirement on LTISystems.

and I removed autodiff=autodiff in 'src/types/options.jl' since it was throwing an error.

This seems to fix the issue. However, it will likely introduce any other bug somewhere else in the code. This is due to the interface change in Optim. We simply need to rewrite the code in a couple of more places to introduce the corresponding changes in Optim, and bump the requirement on Optim, too. Yet, it will be a bit tricky to have such a version bump. Unfortunately, the REQUIRE seems to be going from julia 0.4 to julia 0.6.0-pre in Optim, and then, to julia 0.6. We need to be careful in choosing a proper version in Optim :(

Cc: @neveritt