Fix some issue reported by JET (#244)

Author: lgoettgens

src/Aqua.jl

@@ -78,7 +78,8 @@ function test_all(
     end
     @testset "Compare Project.toml and test/Project.toml" begin
         if project_extras !== false
-            test_project_extras(testtarget; askwargs(project_extras)...)
+            isempty(askwargs(project_extras)) || error("Keyword arguments not supported")
+            test_project_extras(testtarget)
         end
     end
     @testset "Stale dependencies" begin

src/ambiguities.jl

@@ -145,7 +145,7 @@ function _find_ambiguities(
                     strerr,
                 )
 
-                parse(Int, reg_match.captures[1])
+                parse(Int, reg_match.captures[1]::AbstractString)
             end
             return num_ambiguities, strout, strerr
         end

src/deps_compat.jl

@@ -33,7 +33,8 @@ function test_deps_compat(
 )
     if check_julia !== false
         @testset "julia" begin
-            test_julia_compat(pkg; askwargs(check_julia)...)
+            isempty(askwargs(check_julia)) || error("Keyword arguments not supported")
+            test_julia_compat(pkg)
         end
     end
     @testset "$pkg deps" begin
@@ -71,11 +72,11 @@ function test_deps_compat(mod::Module; kwargs...)
     test_deps_compat(aspkgid(mod); kwargs...)
 end
 
-function test_julia_compat(pkg::PkgId; broken::Bool = false, kwargs...)
+function test_julia_compat(pkg::PkgId; broken::Bool = false)
     if broken
-        @test_broken has_julia_compat(pkg; kwargs...)
+        @test_broken has_julia_compat(pkg)
     else
-        @test has_julia_compat(pkg; kwargs...)
+        @test has_julia_compat(pkg)
     end
 end
 

src/pkg/Versions.jl

@@ -94,7 +94,7 @@ function isjoinable(up::VersionBound, lo::VersionBound)
     return true
 end
 
-Base.hash(r::VersionBound, h::UInt) = hash(hash(r.t, h), r.n)
+Base.hash(r::VersionBound, h::UInt) = hash(r.t, hash(r.n, h))
 
 # Hot code
 function VersionBound(s::AbstractString)

src/stale_deps.jl

@@ -68,6 +68,7 @@ function _analyze_stale_deps_1(pkg::PkgId; ignore::AbstractVector{Symbol} = Symb
     output = read(`$cmd --startup-file=no --color=no -e $code`, String)
     @debug("Checked modules loaded in a separate process.", cmd, Text(code), Text(output))
     pos = findfirst(marker, output)
+    @assert !isnothing(pos)
     output = output[pos.stop+1:end]
     loaded_uuids = map(UUID, eachline(IOBuffer(output)))