persistent_tasks: suppress logs from Pkg.jl (#256)

* persistent_tasks: suppress logs from Pkg.jl

By using `io=devnull` option, which is only available in Julia 1.9
and above.

* Add changelog, bump version

* Make killing less noisy

---------

Co-authored-by: Lars Göttgens <[email protected]>

Author: aviatesk

CHANGELOG.md

@@ -7,6 +7,12 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
 
 ## [Unreleased]
 
+## [0.8.3] - 2023-11-29
+
+## Changed
+
+- `test_persistent_tasks` is now less noisy. ([#256](https://github.com/JuliaTesting/Aqua.jl/pull/256))
+
 
 ## [0.8.2] - 2023-11-16
 

Project.toml

@@ -1,7 +1,7 @@
 name = "Aqua"
 uuid = "4c88cf16-eb10-579e-8560-4a9242c79595"
 authors = ["Takafumi Arakaki <[email protected]> and contributors"]
-version = "0.8.2"
+version = "0.8.3"
 
 [deps]
 Compat = "34da2185-b29b-5c13-b0c7-acf172513d20"

src/persistent_tasks.jl

@@ -118,7 +118,7 @@ function find_persistent_tasks_deps(package::Module; kwargs...)
 end
 
 function precompile_wrapper(project, tmax)
-    if VERSION < v"1.10.0-"
+    @static if VERSION < v"1.10.0-"
         return true
     end
     prev_project = Base.active_project()::String
@@ -131,9 +131,9 @@ function precompile_wrapper(project, tmax)
             return false
         end
         wrapperdir = tempname()
-        wrappername, _ = only(Pkg.generate(wrapperdir))
-        Pkg.activate(wrapperdir)
-        Pkg.develop(PackageSpec(path = pkgdir))
+        wrappername, _ = only(Pkg.generate(wrapperdir; io = devnull))
+        Pkg.activate(wrapperdir; io = devnull)
+        Pkg.develop(PackageSpec(path = pkgdir); io = devnull)
         statusfile = joinpath(wrapperdir, "done.log")
         open(joinpath(wrapperdir, "src", wrappername * ".jl"), "w") do io
             println(
@@ -151,7 +151,7 @@ end
             )
         end
         # Precompile the wrapper package
-        cmd = `$(Base.julia_cmd()) --project=$wrapperdir -e 'push!(LOAD_PATH, "@stdlib"); using Pkg; Pkg.precompile()'`
+        cmd = `$(Base.julia_cmd()) --project=$wrapperdir -e 'push!(LOAD_PATH, "@stdlib"); using Pkg; Pkg.precompile(; io = devnull)'`
         proc = run(cmd, stdin, stdout, stderr; wait = false)
         while !isfile(statusfile) && process_running(proc)
             sleep(0.5)
@@ -167,11 +167,11 @@ end
         end
         success = !process_running(proc)
         if !success
-            kill(proc)
+            kill(proc, Base.SIGKILL)
         end
         return success
     finally
         isdefined(Pkg, :respect_sysimage_versions) && Pkg.respect_sysimage_versions(true)
-        Pkg.activate(prev_project)
+        Pkg.activate(prev_project; io = devnull)
     end
 end