more precise filtering, by making isfinal "dynamic"

I.e. even testsets which have children can now be `isfinal`, provided
`resolve!` has decided none of them will run this time.
The filtering is then more precise because only `isfinal` testsets
are filtered at run time, after `resolve!` is done.

Author: rfourquet

src/ReTest.jl

@@ -91,7 +91,9 @@ mutable struct TestsetExpr
 end
 
 isfor(ts::TestsetExpr) = ts.loops !== nothing
-isfinal(ts::TestsetExpr) = isempty(ts.children)
+
+# ts has no children, or at least none which will run this time
+isfinal(ts::TestsetExpr) = all(tsc -> !tsc.run, ts.children)
 
 function tsdepth(ts::Union{TestsetExpr,Testset.ReTestSet})
     d = 1
@@ -467,7 +469,8 @@ eval_desc(mod, ts, x) =
 function make_ts(ts::TestsetExpr, pat::Pattern, stats, chan)
     ts.run || return nothing
 
-    if isfinal(ts)
+    if isempty(ts.children) # not isfinal(ts), so that children which don't run
+                            # are removed from the AST
         body = ts.body
     else
         body = make_ts(ts.body, pat, stats, chan)

test/runtests.jl

@@ -868,6 +868,31 @@ Main.MiscSubmoduleHeader.Sub
 """)
 end
 
+
+module MiscIsFinal
+using ReTest, ..Trace
+
+@testset "outer$i" for i=1:2
+# "outer$i" is apparently non-final, but with the proper filtering pattern,
+# it can become final: then, test that filtering actually happens
+# (once `resolve!` is done, no more filtering happens except for `isfinal` testsets;
+# so here we check that `isfinal` applies to "outer")
+    trace(i)
+    @testset "inner" begin
+        trace(-1)
+    end
+end
+
+end # MiscIsFinal
+
+@chapter MiscIsFinal begin
+    check(MiscIsFinal, r"outer1$", [1])
+    check(MiscIsFinal, r"outer1$", dry=true, id=false, [], output="outer1")
+    check(MiscIsFinal, r"outer2$", [2])
+    check(MiscIsFinal, r"outer2$", dry=true, id=false, [], output="outer2")
+end
+
+
 module Bugs
 using ReTest
 @testset "macros with nothing" begin