Discrepency in Worker ID info between logs and XML report #145
Description
We have seen a single error in the logs that are output while running tests (with runtests(...; nworkers=1, report=true)), like:
Error in testset "Foo" on worker 10469:
Error During Test at /test/foo_test.jl:4
Got exception outside of a @test
Worker process aborted (signal=11) running test item "Foo" (run=1)
No Captured Logs for test item "Foo" at test/jet_test.jl:4 on worker 10469(note worker 10469)
but then in the resulting XML report:
No Captured Logs for test item "Foo" at test/foo_test.jl:4 on worker 10447
┌ Error: Worker(pid=10447, terminated=true, termsignal=11) died running test item "Foo". Recording test error.
└ @ ReTestItems /nix/store/wmnl0wbwlq710087qchdfq2zjxgbm9kp-raicode-pkg-build/packages/ReTestItems/rzEcY/src/ReTestItems.jl:561(note worker 10447)
We have inconsistent information about which worker process terminated.
The logs are correct and the report is wrong.
Possibly because we reset the workerid on each retry (
ReTestItems.jl/src/ReTestItems.jl
Line 504 in a3388ad
workerid for the test-item is out of date (we call print_errors_and_captured_logs which calls _on_worker(ti) and gets incorrect info)