add try_convert

Author: oxinabox

Project.toml

@@ -18,7 +18,7 @@ Unicode = "4ec0a83e-493e-50e2-b9ac-8f72acf5a8f5"
 EzXML = "0.9.1, 1"
 Mocking = "0.7"
 RecipesBase = "0.7, 0.8, 1"
-ShortStrings = 0.3.5
+ShortStrings = "0.3.5"
 julia = "1"
 
 [extras]

src/types/name.jl

@@ -16,7 +16,16 @@ end
 
 Base.convert(::Type{String}, name::SName) = string(name)
 function Base.convert(::Type{SName}, str::AbstractString)
+    name = try_convert(SName, str)
+    name isa Nothing && DomainError(str, "All timezone name parts must have length < 16")
+    return name
+end
+
+try_convert(::Type{SName}, name::SName) = name
+try_convert(::Type{String}, name::String) = name
+function try_convert(::Type{SName}, str::AbstractString)
     parts = split(str, "/"; limit=3)
+    all(length(parts) < 16) ||return nothing
     return if length(parts) == 3
         SName(parts[1], parts[2], parts[3])
     elseif length(parts) == 2
@@ -26,6 +35,7 @@ function Base.convert(::Type{SName}, str::AbstractString)
     end
 end
 
+
 Base.isempty(name::SName) = isempty(name.region)  # region being empty implies all empty
 
 name_parts(str::AbstractString) = split(str, "/")

src/types/timezone.jl

@@ -100,7 +100,8 @@ function istimezone(str::Union{AbstractString, Name}, mask::Class=Class(:DEFAULT
     if mask & Class(:FIXED) != Class(:NONE) && occursin(FIXED_TIME_ZONE_REGEX, string(str))
         return true
     end
-    name = convert(Name, str)
+    name = try_convert(Name, str)
+    name isa Nothing && return false
 
     # Perform more expensive checks against pre-compiled time zones
     tz, class = get(TIME_ZONE_CACHE, str) do

src/tzdata/compile.jl

@@ -4,7 +4,7 @@ using Dates: parse_components
 
 using ...TimeZones: TIME_ZONE_CACHE
 using ...TimeZones: TimeZones, TimeZone, FixedTimeZone, VariableTimeZone, Transition, Class
-using ...TimeZones: name_parts, rename
+using ...TimeZones: name_parts, rename, try_convert
 using ..TZData: TimeOffset, ZERO, MIN_GMT_OFFSET, MAX_GMT_OFFSET, MIN_SAVE, MAX_SAVE,
     ABS_DIFF_OFFSET