Skip to content

Commit e188595

Browse files
committed
fix(workflows/docker-parallel-multiarch-build): move registry-username to inputs
sometimes username is part of image name, so it blocks outputs from build jobs
1 parent 2965f4e commit e188595

File tree

2 files changed

+6
-5
lines changed

2 files changed

+6
-5
lines changed

.github/workflows/docker-parallel-multiarch-build.yml

Lines changed: 5 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -42,12 +42,13 @@ on:
4242
default: ghcr.io
4343
required: false
4444
type: string
45+
registry-username:
46+
required: true
47+
type: string
4548
image-name:
4649
required: true
4750
type: string
4851
secrets:
49-
registry-username:
50-
required: true
5152
registry-password:
5253
required: true
5354

@@ -98,7 +99,7 @@ jobs:
9899
uses: docker/login-action@74a5d142397b4f367a81961eba4e8cd7edddf772 # v3.4.0
99100
with:
100101
registry: ${{ inputs.registry }}
101-
username: ${{ secrets.registry-username }}
102+
username: ${{ inputs.registry-username }}
102103
password: ${{ secrets.registry-password }}
103104

104105
- name: Extract Docker metadata
@@ -216,7 +217,7 @@ jobs:
216217
uses: docker/login-action@74a5d142397b4f367a81961eba4e8cd7edddf772 # v3.4.0
217218
with:
218219
registry: ${{ inputs.registry }}
219-
username: ${{ secrets.registry-username }}
220+
username: ${{ inputs.registry-username }}
220221
password: ${{ secrets.registry-password }}
221222

222223
- name: Extract Docker metadata

.github/workflows/docker-publish.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -64,7 +64,7 @@ jobs:
6464
revision: ${{ matrix.revision }}
6565
platforms: ${{ matrix.platforms }}
6666
registry: ghcr.io
67+
registry-username: ${{ github.actor }}
6768
image-name: ${{ github.repository }}/${{ matrix.container }}
6869
secrets:
69-
registry-username: ${{ github.actor }}
7070
registry-password: ${{ secrets.GITHUB_TOKEN }}

0 commit comments

Comments
 (0)