Merge pull request #196 from JunoLab/avi/quote

prevent items inside quotes from leaking into outline

Author: aviatesk

src/outline.jl

@@ -332,12 +332,16 @@ function scopeof(expr::CSTParser.EXPR)
             return :call
         end
 
+        if expr.typ == CSTParser.TupleH && expr.parent ≠ nothing && scopeof(expr.parent) == nothing
+            return :tupleh
+        end
+
         if expr.typ == CSTParser.MacroCall
             return :macro
         end
 
-        if expr.typ == CSTParser.TupleH && expr.parent ≠ nothing && scopeof(expr.parent) == nothing
-            return :tupleh
+        if expr.typ == CSTParser.Quote
+            return :quote
         end
     end
     return nothing

test/outline.jl

@@ -286,6 +286,20 @@ end
         end
     end
 
+    # items inside quote blocks don't leak
+    let str = """
+        ex = :(func() = nothing)
+        q = quote
+            @macrocall something
+            val = nothing
+        end
+        """
+        let names = Set(map(d -> d[:name], outline(str)))
+            @test length(names) === 2
+            @test names == Set(("ex", "q"))
+        end
+    end
+
     # should stringify method signatures correctly
     let str = """
         withstrings(single = \"1\", triple = \"\"\"3\"\"\") = single * triple