Merge pull request #240 from JunoLab/sp/canopyfix

aviatesk · web-flow · commit eed6cb725c9b · 2019-11-12T08:24:18.000+09:00
fix readAfterUpdate in canopy
diff --git a/lib/plots/canopy.js b/lib/plots/canopy.js
@@ -96,6 +96,8 @@ export class Pannable extends Etch {
   }
 
   readAfterUpdate () {
+    this.containerRect =
+      this.element.getElementsByClassName('ink-pannable')[0].getBoundingClientRect()
     this.setInitialScale(this.item)
     etch.update(this)
   }
@@ -196,11 +198,6 @@ export class Pannable extends Etch {
     </div>;
   }
 
-  readAfterUpdate () {
-    this.containerRect =
-      this.element.getElementsByClassName('ink-pannable')[0].getBoundingClientRect()
-  }
-
   teardown () {
     if (this.item && this.item.teardown) this.item.teardown()
     etch.update(this)

Original file line number	Diff line number	Diff line change
`@@ -96,6 +96,8 @@ export class Pannable extends Etch {`
`96`	`96`	`}`
`97`	`97`
`98`	`98`	`readAfterUpdate () {`
	`99`	`+ this.containerRect =`
	`100`	`+ this.element.getElementsByClassName('ink-pannable')[0].getBoundingClientRect()`
`99`	`101`	`this.setInitialScale(this.item)`
`100`	`102`	`etch.update(this)`
`101`	`103`	`}`
`@@ -196,11 +198,6 @@ export class Pannable extends Etch {`
`196`	`198`	`</div>;`
`197`	`199`	`}`
`198`	`200`
`199`		`- readAfterUpdate () {`
`200`		`- this.containerRect =`
`201`		`- this.element.getElementsByClassName('ink-pannable')[0].getBoundingClientRect()`
`202`		`- }`
`203`		`-`
`204`	`201`	`teardown () {`
`205`	`202`	`if (this.item && this.item.teardown) this.item.teardown()`
`206`	`203`	`etch.update(this)`