show release note in modal

Author: aviatesk

lib/julia-client.coffee

@@ -44,9 +44,11 @@ module.exports = JuliaClient =
           minor = semver.minor(LATEST_RELEASE_NOTE_VERSION)
           if semver.minor(v) < minor
             major = semver.major(LATEST_RELEASE_NOTE_VERSION)
-            release.showStartupNote("#{major}.#{minor}.0") # current minor release
+            release.activate("#{major}.#{minor}.0") # current minor release
           else
-            release.showStartupNote(LATEST_RELEASE_NOTE_VERSION) # current patch
+            release.activate(LATEST_RELEASE_NOTE_VERSION) # current patch
+        else
+          release.activate()
       catch err
         console.log(err)
       finally
@@ -131,11 +133,10 @@ module.exports = JuliaClient =
   config: config
 
   deactivate: ->
-    x.deactivate() for x in [commands, menu, toolbar, @connection, @runtime, @ui]
+    x.deactivate() for x in [commands, menu, toolbar, release, @connection, @runtime, @ui]
 
   consumeInk: (ink) ->
     commands.ink = ink
-    release.activate(ink)
     x.consumeInk ink for x in [@connection, @runtime, @ui]
 
   consumeStatusBar: (bar) -> @runtime.consumeStatusBar bar

lib/package/release-note.js

@@ -1,24 +1,32 @@
 /** @babel */
 
-import { CompositeDisposable } from 'atom'
+import { CompositeDisposable, Disposable } from 'atom'
 import path from 'path'
 import fs from 'fs'
+import marked from 'marked'
 import { show } from '../ui/selector'
 import { readCode } from '../misc/paths'
 
-let startupNoteVersion, subs
+let subs
 const RELEASE_NOTE_DIR = path.join(__dirname, '..', '..', 'release-notes')
 
-export function activate (ink) {
-  const pane = ink.NotePane.fromId('Note')
+export function activate (startupNoteVersion) {
+  subs = new CompositeDisposable()
+  const view = document.createElement('div')
+  view.classList.add('julia-client-release-note')
+  const panel = atom.workspace.addModalPanel({ item: view })
   const showNote = (version) => {
     const p = path.join(RELEASE_NOTE_DIR, version + '.md')
     const markdown = readCode(p)
-    pane.setNote(markdown)
-    pane.setTitle(`Juno release note – v${version}`)
-    pane.ensureVisible()
+    view.innerHTML = marked(markdown)
+    panel.show()
   }
-  subs = new CompositeDisposable()
+  const close = () => {
+    panel.hide()
+  }
+  const panelView = panel.getElement()
+  panelView.style['max-width'] = '75em'
+  panelView.addEventListener('blur', close) // BUG: doesn't work
   subs.add(
     atom.commands.add('atom-workspace',  'julia-client:open-release-note', () => {
       const versions = fs.readdirSync(RELEASE_NOTE_DIR)
@@ -27,13 +35,12 @@ export function activate (ink) {
       show(versions)
         .then(version => showNote(version.replace(/v\s(.+)/, '$1')))
         .catch(err => console.log(err))
+    }),
+    new Disposable(() => {
+      panel.destroy()
     })
   )
-  if (startupNoteVersion) showNote(startupNoteVersion)
-}
-
-export function showStartupNote (version) {
-  startupNoteVersion = version
+  if (startupNoteVersion) showNote(startupNoteVersion) // BUG: doesn't work
 }
 
 export function deactivate () {

package-lock.json

@@ -29,6 +29,7 @@
     "atom-space-pen-views": "^2.0.0",
     "etch": "^0.14",
     "fuzzaldrin-plus": "^0.6.0",
+    "marked": "^0.8.2",
     "node-pty-prebuilt-multiarch": "0.9.0",
     "object-hash": "^2.0.3",
     "physical-cpu-count": "*",

package.json

@@ -191,3 +191,13 @@ atom-text-editor.editor[data-grammar$="source weave latex"] {
   position: absolute;
   border: 1px solid fade(@text-color, 70%);
 }
+
+.julia-client-release-note {
+  overflow: auto  !important;
+  font-size: var(--editor-font-size);
+  padding: 1em;
+  img {
+    max-height: 20em;
+    display: block;
+  }
+}