Merge pull request #647 from JunoLab/sp/maxplotnumber

make max number of plots configurable

Author: pfitzseb

lib/julia-client.coffee

@@ -8,7 +8,7 @@ toolbar = require './package/toolbar'
 semver = require 'semver'
 
 # TODO: Update me when tagging a new relase:
-INK_VERSION_COMPAT  = "^0.11.2"
+INK_VERSION_COMPAT  = "^0.11.6"
 
 INK_LINK            = '[`ink`](https://github.com/JunoLab/atom-ink)'
 LANGUAGE_JULIA_LINK = '[`language-julia`](https://github.com/JuliaEditorSupport/atom-language-julia)'

lib/package/config.coffee

@@ -410,6 +410,12 @@ config =
             type: 'boolean'
             default: true
             order: 11
+      maxNumberPlots:
+        title: 'Maximum Number of Plots in History'
+        type: 'number'
+        description: 'Increasing this number may lead to high memory consumption and poor performance.'
+        default: 50
+        order: 12
   consoleOptions:
     type: 'object'
     title: 'Terminal Options'

lib/runtime/plots.js

@@ -60,7 +60,9 @@ export default {
   show (view) {
     this.ensureVisible()
     const v = views.render(view)
-    this.pane.show(new this.ink.Pannable(v))
+    this.pane.show(new this.ink.Pannable(v), {
+      maxSize: atom.config.get('julia-client.uiOptions.maxNumberPlots')
+    })
     return v
   },
 
@@ -88,7 +90,9 @@ export default {
   ploturl (url) {
     const v = this.webview(url)
     this.ensureVisible()
-    return this.pane.show(v)
+    return this.pane.show(v, {
+      maxSize: atom.config.get('julia-client.uiOptions.maxNumberPlots')
+    })
   },
 
   jlpane (id, opts) {