Skip to content

Commit 2d6673b

Browse files
authored
Merge pull request #631 from JunoLab/sp/lingo
more consistent lingo
2 parents 5fb3e44 + def8fd7 commit 2d6673b

File tree

8 files changed

+28
-29
lines changed

8 files changed

+28
-29
lines changed

keymaps/julia-client.cson.cmd

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -41,9 +41,9 @@ Any global commands should either be non-default or, ideally, prefixed with `C-J
4141

4242
# atom-workspace
4343
'.platform-darwin atom-workspace':
44-
'cmd-j cmd-r': 'julia-client:open-a-repl'
45-
'cmd-j cmd-o': 'julia-client:open-console'
46-
'cmd-j cmd-c': 'julia-client:clear-console'
44+
'cmd-j cmd-r': 'julia-client:open-external-repl'
45+
'cmd-j cmd-o': 'julia-client:open-REPL'
46+
'cmd-j cmd-c': 'julia-client:clear-REPL'
4747
'cmd-j cmd-s': 'julia-client:start-julia'
4848
'cmd-j cmd-k': 'julia-client:kill-julia'
4949
'cmd-j cmd-p': 'julia-client:open-plot-pane'

keymaps/julia-client.cson.ctrl

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -47,9 +47,9 @@ Any global commands should either be non-default or, ideally, prefixed with `C-J
4747
# atom-workspace
4848
'.platform-win32 atom-workspace,
4949
.platform-linux atom-workspace':
50-
'ctrl-j ctrl-r': 'julia-client:open-a-repl'
51-
'ctrl-j ctrl-o': 'julia-client:open-console'
52-
'ctrl-j ctrl-c': 'julia-client:clear-console'
50+
'ctrl-j ctrl-r': 'julia-client:open-external-repl'
51+
'ctrl-j ctrl-o': 'julia-client:open-REPL'
52+
'ctrl-j ctrl-c': 'julia-client:clear-REPL'
5353
'ctrl-j ctrl-s': 'julia-client:start-julia'
5454
'ctrl-j ctrl-k': 'julia-client:kill-julia'
5555
'ctrl-j ctrl-p': 'julia-client:open-plot-pane'

lib/connection/messages.coffee

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -36,7 +36,7 @@ module.exports =
3636
description:
3737
"""
3838
Julia's first run will take a couple of minutes.
39-
See the console below for progress.
39+
See the REPL below for progress.
4040
"""
4141
dismissable: true
4242
@openConsole()
@@ -47,7 +47,7 @@ module.exports =
4747
description:
4848
"""
4949
Julia's first run will take a couple of minutes.
50-
See the console below for progress.
50+
See the REPL below for progress.
5151
"""
5252
dismissable: true
5353
@openConsole()
@@ -58,14 +58,14 @@ module.exports =
5858
description:
5959
"""
6060
Success! Juno is set up and ready to roll.
61-
Try entering `2+2` in the console below.
61+
Try entering `2+2` in the REPL below.
6262
"""
6363
dismissable: true
6464
@openConsole()
6565

6666
openConsole: ->
6767
atom.commands.dispatch atom.views.getView(atom.workspace),
68-
'julia-client:open-console'
68+
'julia-client:open-REPL'
6969

7070
jlNotFound: (path, details = '') ->
7171
atom.notifications.addError "Julia could not be started.",

lib/package/commands.coffee

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -83,7 +83,7 @@ module.exports =
8383

8484
# atom-work-space
8585
@subs.add atom.commands.add 'atom-workspace',
86-
'julia-client:open-a-repl': -> juno.connection.terminal.repl()
86+
'julia-client:open-external-repl': -> juno.connection.terminal.repl()
8787
'julia-client:start-julia': -> disrequireClient 'boot Julia', -> boot()
8888
'julia-client:start-remote-julia-process': -> disrequireClient 'boot a remote Julia process', -> juno.connection.bootRemote()
8989
'julia-client:kill-julia': -> juno.connection.client.kill()

lib/package/config.coffee

Lines changed: 5 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -112,7 +112,7 @@ config =
112112
enum: [
113113
{value:'inline', description:'Float results next to code'}
114114
{value:'block', description:'Display results under code'}
115-
{value:'console', description:'Display results in the console'}
115+
{value:'console', description:'Display results in the REPL'}
116116
]
117117
order: 1
118118
scrollToResult:
@@ -180,20 +180,20 @@ config =
180180
collapsed: true
181181
properties:
182182
console:
183-
title: 'Console'
183+
title: 'REPL'
184184
type: 'object'
185185
order: 1
186186
collapsed: true
187187
properties:
188188
defaultLocation:
189-
title: 'Default location of Console Pane'
189+
title: 'Default location of REPL Pane'
190190
type: 'string'
191191
enum: ['center', 'left', 'bottom', 'right']
192192
default: 'bottom'
193193
radio: true
194194
order: 1
195195
split:
196-
title: 'Splitting rule of Console Pane'
196+
title: 'Splitting rule of REPL Pane'
197197
type: 'string'
198198
enum: ['no split', 'left', 'up', 'right', 'down']
199199
default: 'no split'
@@ -412,6 +412,7 @@ config =
412412
order: 11
413413
consoleOptions:
414414
type: 'object'
415+
title: 'Terminal Options'
415416
order: 4
416417
collapsed: true
417418
properties:

lib/package/menu.coffee

Lines changed: 7 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -26,9 +26,12 @@ module.exports =
2626
{label: 'Start Remote Julia Process', command: 'julia-client:start-remote-julia-process'}
2727
{label: 'Interrupt Julia', command: 'julia-client:interrupt-julia'}
2828
{label: 'Stop Julia', command: 'julia-client:kill-julia'}
29-
{label: 'Open Console', command: 'julia-client:open-console'}
30-
{label: 'Clear Console', command: 'julia-client:clear-console'}
31-
{label: 'Open REPL', command: 'julia-client:open-a-repl'}
29+
30+
{type: 'separator'}
31+
32+
{label: 'Open REPL', command: 'julia-client:open-REPL'}
33+
{label: 'Clear REPL', command: 'julia-client:clear-REPL'}
34+
{label: 'Open External REPL', command: 'julia-client:open-external-repl'}
3235
{
3336
label: 'Working Directory'
3437
submenu: [
@@ -38,12 +41,7 @@ module.exports =
3841
{label: 'Select...', command: 'julia-client:select-working-folder'}
3942
]
4043
}
41-
{
42-
label: 'Working Module'
43-
submenu: [
44-
{label: 'Select...', command: 'julia-client:select-working-module'}
45-
]
46-
}
44+
{label: 'Select Working Module', command: 'julia-client:select-working-module'}
4745

4846
{type: 'separator'}
4947

lib/package/toolbar.coffee

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -80,8 +80,8 @@ module.exports =
8080

8181
@bar.addButton
8282
icon: 'terminal'
83-
tooltip: 'Show Console'
84-
callback: 'julia-client:open-console'
83+
tooltip: 'Show REPL'
84+
callback: 'julia-client:open-REPL'
8585

8686
@bar.addButton
8787
icon: 'book'
@@ -100,7 +100,7 @@ module.exports =
100100

101101
@bar.addButton
102102
icon: 'graph'
103-
tooltip: 'Show Plots'
103+
tooltip: 'Show Plot Pane'
104104
callback: 'julia-client:open-plot-pane'
105105

106106
@bar.addButton

lib/runtime/console.js

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -107,11 +107,11 @@ export function activate (_ink) {
107107
if (promptObserver) promptObserver.dispose()
108108
})
109109

110-
subs.add(atom.commands.add('atom-workspace', 'julia-client:open-console', () => {
110+
subs.add(atom.commands.add('atom-workspace', 'julia-client:open-REPL', () => {
111111
open().then(() => terminal.show())
112112
}))
113113

114-
subs.add(atom.commands.add('atom-workspace', 'julia-client:clear-console', () => {
114+
subs.add(atom.commands.add('atom-workspace', 'julia-client:clear-REPL', () => {
115115
terminal.clear()
116116
}))
117117

0 commit comments

Comments
 (0)