better messaging & suppress field renaming

Author: aviatesk

lib/package/commands.coffee

@@ -55,7 +55,7 @@ module.exports =
         'julia-client:rename-refactor': =>
           @withInk ->
             boot()
-            juno.runtime.refactor.refactor()
+            juno.runtime.refactor.renameRefactor()
         # @NOTE: `'clear-workspace'` is now not handled by Atom.jl
         # 'julia-client:reset-workspace': =>
         #   requireClient 'reset the workspace', ->

lib/runtime/refactor.js

@@ -5,15 +5,15 @@ import modules from './modules'
 import { getWordRangeAtBufferPosition, isValidWordToInspect } from '../misc/words'
 import { getLocalContext } from '../misc/blocks'
 
-const { refactor: _refactor } = client.import(['refactor'])
+const renamerefactor = client.import('renamerefactor')
 const wordRegexWithoutDotAccessor = /@?[\u00A0-\uFFFF\w_!´]+/
 
 class Refactor {
   activate (ink) {
     this.ink = ink
   }
 
-  refactor () {
+  renameRefactor () {
     const editor = atom.workspace.getActiveTextEditor()
     const bufferPosition = editor.getCursorBufferPosition()
 
@@ -24,6 +24,9 @@ class Refactor {
     const old = editor.getTextInBufferRange(range)
     if (!isValidWordToInspect(old)) return
 
+    const rangeFull = getWordRangeAtBufferPosition(editor, bufferPosition)
+    const full = editor.getTextInBufferRange(rangeFull)
+
     this.ink.showBasicModal([{
       name: 'Rename',
       defaultText: old,
@@ -46,8 +49,9 @@ class Refactor {
       const currentModule = modules.current()
       const mod = currentModule ? currentModule : 'Main'
 
-      _refactor({
+      renamerefactor({
         old,
+        full,
         new: _new,
         path: editor.getPath(),
         // local context
@@ -58,15 +62,30 @@ class Refactor {
         // module context
         mod,
       }).then(result => {
-        if (result.error) {
+        // local refactoring
+        if (result.text) {
+          editor.setTextInBufferRange(range, result.text)
+        }
+        if (result.info) {
+          atom.notifications.addInfo('Julia Client: Rename Refactor', {
+            description: result.info,
+            dismissable: true
+          })
+        }
+        if (result.warning) {
           atom.notifications.addWarning('Julia Client: Rename Refactor', {
+            description: result.warning
+          })
+        }
+        if (result.error) {
+          atom.notifications.addError('Julia Client: Rename Refactor', {
             description: result.error
           })
-          return
         }
-        // local refactoring
-        if (result.text) {
-          editor.setTextInBufferRange(range, result.text)
+        if (result.success) {
+          atom.notifications.addSuccess('Julia Client: Rename Refactor', {
+            description: result.success
+          })
         }
       })
     }).catch((err) => {