Merge pull request #635 from JunoLab/sp/remoteaaaaaaaah

fix remote exec escaping

Author: pfitzseb

lib/connection/process/remote.js

@@ -168,30 +168,41 @@ export function get_ (path, args) {
             }
           })
           let jlpath = atom.config.get('julia-client.remoteOptions.remoteJulia')
+
+          // construct something like
+          //
+          // /bin/sh -c 'tmux new -s sessionname '\'' julia -i -e '\'\\\'\''startup_repl'\'\\\'\'' '\''port'\'' '\'' '
+          //
+          // with properly escaped single quotes.
+
           let exec = ''
           if (atom.config.get('julia-client.remoteOptions.tmux')) {
             let sessionName = atom.config.get('julia-client.remoteOptions.tmuxName')
-            exec += '/bin/sh -c \''
-            exec += `tmux new -s ${sessionName} \\"`
+            exec += `/bin/sh -c '`
+            exec += `tmux new -s ${sessionName} '\\''`
             if (threadCount() !== undefined) {
-              exec += ` JULIA_NUM_THREADS='${threadCount()}' `
+              exec += ` JULIA_NUM_THREADS="${threadCount()}" `
             }
             exec += jlpath
-            exec += ' ' + args.join(' ')  + ' -e \'\\\'\''
+            exec += ` ${args.join(' ')} -e '\\'\\\\\\'\\''`
+            // could automatically escape single quotes with `replace(/'/, `'\\'\\\\\\'\\\\\\\\\\\\\\'\\\\\\'\\''`)`,
+            // but that's so ugly I'd rather not do that
             exec += fs.readFileSync(paths.script('boot_repl.jl')).toString()
-            exec += '\'\\\'\' ' + port + ' \\" '
-            exec += `|| tmux send-keys -t ${sessionName}.left ^A ^K ^H \'\\\'\'Juno.connect(${port})\'\\\'\' ENTER `
+            exec += `'\\'\\\\\\'\\'' ${port} '\\'' `
+            exec += `|| tmux send-keys -t ${sessionName}.left ^A ^K ^H '\\''Juno.connect(${port})'\\'' ENTER `
             exec += `&& tmux attach -t ${sessionName} `
-            exec += '\''
+            exec += `'`
           } else {
-            exec += '/bin/sh -c \''
+            exec += `/bin/sh -c '`
             if (threadCount() !== undefined) {
-              exec += `JULIA_NUM_THREADS='${threadCount()}' `
+              exec += `JULIA_NUM_THREADS="${threadCount()}" `
             }
-            exec += jlpath + ' ' + args.join(' ')  + ' -e \'\\\'\''
+            exec += `${jlpath} ${args.join(' ')} -e '\\''`
+            // could automatically escape single quotes with `replace(/'/, `'\\'\\\\\\'\\''`)`,
+            // but that's so ugly I'd rather not do that
             exec += fs.readFileSync(paths.script('boot_repl.jl')).toString()
-            exec += '\'\\\'\' ' + port
-            exec += '\''
+            exec += `'\\'' ${port}`
+            exec += `'`
           }
 
           conn.exec(exec, { pty: { term: "xterm-256color" } }, (err, stream) => {

script/boot_repl.jl

@@ -1,4 +1,5 @@
 let
+# NOTE: Single quotes in this file break remote execution. So dont use them.
 if VERSION > v"0.7-"
   port = parse(Int, popfirst!(ARGS))
 else