show release note in as an usual pane

Author: aviatesk

keymaps/julia-client.cson.cmd

@@ -41,10 +41,6 @@ Any global commands should either be non-default or, ideally, prefixed with `C-J
   'ctrl-c': 'julia-client:interrupt-julia'
   'cmd-j cmd-m': 'julia-client:set-working-module'
 
-# release note
-'.julia-client-release-note':
-  'escape': 'julia-client:cancel-release-note'
-
 # atom-workspace
 '.platform-darwin atom-workspace':
   'cmd-j cmd-r': 'julia-client:open-external-REPL'

keymaps/julia-client.cson.ctrl

@@ -46,10 +46,6 @@ Any global commands should either be non-default or, ideally, prefixed with `C-J
   'ctrl-shift-c': 'julia-client:copy-or-interrupt'
   'ctrl-v': 'ink-terminal:paste'
 
-# release note
-'.julia-client-release-note':
-  'escape': 'julia-client:cancel-release-note'
-
 # atom-workspace
 '.platform-win32 atom-workspace,
  .platform-linux atom-workspace':

lib/julia-client.coffee

@@ -37,17 +37,6 @@ module.exports = JuliaClient =
         if atom.config.get('julia-client.uiOptions.layouts.openDefaultPanesOnStartUp')
           setTimeout (=> @ui.layout.restoreDefaultLayout()), 150
 
-      try
-        v = atom.config.get('julia-client.currentVersion')
-        if v isnt LATEST_RELEASE_NOTE_VERSION
-          release.activate(LATEST_RELEASE_NOTE_VERSION)
-        else
-          release.activate()
-      catch err
-        console.log(err)
-      finally
-        atom.config.set('julia-client.currentVersion', LATEST_RELEASE_NOTE_VERSION)
-
   requireDeps: (fn) ->
     isLoaded = atom.packages.isPackageLoaded("ink") and atom.packages.isPackageLoaded("language-julia")
 
@@ -131,6 +120,16 @@ module.exports = JuliaClient =
   consumeInk: (ink) ->
     commands.ink = ink
     x.consumeInk ink for x in [@connection, @runtime, @ui]
+    try
+      v = atom.config.get('julia-client.currentVersion')
+      if v isnt LATEST_RELEASE_NOTE_VERSION
+        release.activate(ink, LATEST_RELEASE_NOTE_VERSION)
+      else
+        release.activate(ink)
+    catch err
+      console.log(err)
+    finally
+      atom.config.set('julia-client.currentVersion', LATEST_RELEASE_NOTE_VERSION)
 
   consumeStatusBar: (bar) -> @runtime.consumeStatusBar bar
 

lib/package/release-note.js

@@ -10,32 +10,17 @@ import { readCode } from '../misc/paths'
 let subs
 const RELEASE_NOTE_DIR = path.join(__dirname, '..', '..', 'release-notes')
 
-export function activate (startupNoteVersion) {
+export function activate (ink, startupNoteVersion) {
+  const pane = ink.NotePane.fromId('Note')
   subs = new CompositeDisposable()
-  const view = document.createElement('div')
-  const panel = atom.workspace.addModalPanel({ item: view })
 
-  const inner = document.createElement('div')
-  inner.classList.add('julia-client-release-note')
-  inner.setAttribute('tabindex', "1")
-
-  const closeButton = document.createElement('button')
-  closeButton.classList.add('btn', 'icon', 'icon-remove-close', 'release-note-close-button')
-
-  view.appendChild(closeButton)
-  view.appendChild(inner)
-
-  const showNote = (version, versions) => {
+  const showNote = (version) => {
     const p = path.join(RELEASE_NOTE_DIR, version + '.md')
     const markdown = readCode(p)
-    inner.innerHTML = marked(markdown)
-    panel.show()
-    view.focus()
+    pane.setNote(markdown)
+    pane.setTitle(`Juno release note – v${version}`)
+    pane.ensureVisible()
   }
-  const close = () => panel.hide()
-  closeButton.onclick = close
-  const panelView = panel.getElement()
-  panelView.style['max-width'] = '75em'
 
   subs.add(
     atom.commands.add('atom-workspace', 'julia-client:open-release-note', () => {
@@ -45,18 +30,9 @@ export function activate (startupNoteVersion) {
       show(versions)
         .then(version => showNote(version.replace(/v\s(.+)/, '$1')))
         .catch(err => console.log(err))
-    }),
-    atom.commands.add(panelView, 'julia-client:cancel-release-note',  (event) => {
-      close()
-      event.stopPropagation()
-    }),
-    atom.packages.onDidActivateInitialPackages(() => {
-      if (startupNoteVersion) setTimeout(() => showNote(startupNoteVersion), 500)
-    }),
-    new Disposable(() => {
-      panel.destroy()
     })
   )
+  if (startupNoteVersion) showNote(startupNoteVersion)
 }
 
 export function deactivate () {

package-lock.json

@@ -29,7 +29,6 @@
     "atom-select-list": "^0.7.2",
     "etch": "^0.14",
     "fuzzaldrin-plus": "^0.6.0",
-    "marked": "^0.8.2",
     "node-pty-prebuilt-multiarch": "0.9.0",
     "object-hash": "^2.0.3",
     "physical-cpu-count": "*",

package.json

@@ -191,20 +191,3 @@ atom-text-editor.editor[data-grammar$="source weave latex"] {
   position: absolute;
   border: 1px solid fade(@text-color, 70%);
 }
-
-.julia-client-release-note {
-  font-size: var(--editor-font-size);
-  padding: 1em;
-  img {
-    max-height: 20em;
-    display: block;
-  }
-
-  max-height: 90vh;
-  overflow: auto;
-}
-
-.release-note-close-button {
-  position: absolute;
-  right: 1em;
-}