some fixes

Author: pfitzseb

lib/julia-client.coffee

@@ -40,20 +40,15 @@ module.exports = JuliaClient =
 
       try
         v = atom.config.get('julia-client.currentVersion')
-        if not semver.gte(v, LATEST_RELEASE_NOTE_VERSION)
-          minor = semver.minor(LATEST_RELEASE_NOTE_VERSION)
-          if semver.minor(v) < minor
-            major = semver.major(LATEST_RELEASE_NOTE_VERSION)
-            release.activate("#{major}.#{minor}.0") # current minor release
-          else
-            release.activate(LATEST_RELEASE_NOTE_VERSION) # current patch
+        if v isnt LATEST_RELEASE_NOTE_VERSION
+          atom.config.set('julia-client.currentVersion', LATEST_RELEASE_NOTE_VERSION)
+          release.activate(LATEST_RELEASE_NOTE_VERSION)
         else
           release.activate()
       catch err
         console.log(err)
       finally
-        juliaClientVersion = atom.packages.loadedPackages["julia-client"].metadata.version
-        atom.config.set('julia-client.currentVersion', juliaClientVersion)
+        atom.config.set('julia-client.currentVersion', LATEST_RELEASE_NOTE_VERSION)
 
   requireDeps: (fn) ->
     isLoaded = atom.packages.isPackageLoaded("ink") and atom.packages.isPackageLoaded("language-julia")

lib/package/release-note.js

@@ -13,22 +13,35 @@ const RELEASE_NOTE_DIR = path.join(__dirname, '..', '..', 'release-notes')
 export function activate (startupNoteVersion) {
   subs = new CompositeDisposable()
   const view = document.createElement('div')
-  view.classList.add('julia-client-release-note')
   const panel = atom.workspace.addModalPanel({ item: view })
-  const showNote = (version) => {
+
+  const inner = document.createElement('div')
+  inner.classList.add('julia-client-release-note')
+  inner.setAttribute('tabindex', "1")
+
+  const closeButton = document.createElement('button')
+  closeButton.classList.add('btn', 'icon', 'icon-remove-close', 'release-note-close-button')
+
+  view.appendChild(closeButton)
+  view.appendChild(inner)
+
+  closeButton.onclick = () => panel.hide()
+
+  const showNote = (version, versions) => {
     const p = path.join(RELEASE_NOTE_DIR, version + '.md')
     const markdown = readCode(p)
-    view.innerHTML = marked(markdown)
+    inner.innerHTML = marked(markdown)
     panel.show()
+    view.focus()
   }
   const close = () => {
     panel.hide()
   }
   const panelView = panel.getElement()
   panelView.style['max-width'] = '75em'
-  panelView.addEventListener('blur', close) // BUG: doesn't work
+
   subs.add(
-    atom.commands.add('atom-workspace',  'julia-client:open-release-note', () => {
+    atom.commands.add('atom-workspace', 'julia-client:open-release-note', () => {
       const versions = fs.readdirSync(RELEASE_NOTE_DIR)
         .filter(path => path !== 'README.md')
         .map(path => path.replace(/(.+)\.md/, 'v $1'))
@@ -38,9 +51,17 @@ export function activate (startupNoteVersion) {
     }),
     new Disposable(() => {
       panel.destroy()
+    }),
+    atom.commands.add(panelView, 'julia-client:cancel-release-note',  (event) => {
+      console.log(event);
+      panel.hide()
+      event.stopPropagation()
     })
   )
-  if (startupNoteVersion) showNote(startupNoteVersion) // BUG: doesn't work
+
+  if (startupNoteVersion) {
+    setTimeout(() => showNote(startupNoteVersion), 500)
+  }
 }
 
 export function deactivate () {

styles/julia-client.less

@@ -201,3 +201,13 @@ atom-text-editor.editor[data-grammar$="source weave latex"] {
     display: block;
   }
 }
+
+.julia-client-release-note {
+  max-height: 90vh;
+  overflow: scroll;
+}
+
+.release-note-close-button {
+  position: absolute;
+  right: 1em;
+}