fix process killing

so we don't crash Atom anymore

Author: pfitzseb

lib/connection/process/basic.js

@@ -20,7 +20,7 @@ export function get (path, args) {
 
 export function get_ (path, args) {
   const env = customEnv()
-  return getUnix(path, args, env)
+  return getProcess(path, args, env)
 }
 
 export function customEnv (env = process.env) {
@@ -43,7 +43,7 @@ export function customEnv (env = process.env) {
   return env
 }
 
-function getUnix (path, args, env) {
+function getProcess (path, args, env) {
   return new Promise((resolve, reject) => {
     tcp.listen().then((port) => {
       paths.fullPath(path).then((path) => {
@@ -54,16 +54,27 @@ function getUnix (path, args, env) {
             rows: 30,
             env: env,
             cwd: cwd,
-            useConpty: true
+            useConpty: true,
+            handleFlowControl: true
           })
 
           let sock = socket(ty)
 
-          sock.catch((err) => reject(err))
+          sock.catch((err) => {
+            reject(err)
+          })
 
           let proc = {
             ty: ty,
-            kill: () => ty.kill(),
+            kill: () => {
+              if (ty._readable || ty._writable) {
+                try {
+                  ty.kill()
+                } catch (err) {
+                  console.log(err);
+                }
+              }
+            },
             interrupt: () => ty.write('\x03'),
             socket: sock,
             onExit: (f) => ty.on('exit', f),
@@ -84,17 +95,6 @@ function getUnix (path, args, env) {
   })
 }
 
-function freePort() {
-  return new Promise((resolve) => {
-    let server = net.createServer()
-    server.listen(0, '127.0.0.1', () => {
-      let port = server.address().port
-      server.close()
-      resolve(port)
-    })
-  })
-}
-
 function socket (ty) {
   conn = tcp.next()
   failure = new Promise((resolve, reject) => {