Skip to content

Commit bb8fe70

Browse files
committed
Fix dynamic requires
1 parent dada8c9 commit bb8fe70

File tree

1 file changed

+14
-6
lines changed

1 file changed

+14
-6
lines changed

lib/connection.js

Lines changed: 14 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -2,13 +2,21 @@
22
import { time } from './misc';
33
import externalTerminal from './connection/terminal';
44

5+
// TODO use babel to export ... from ...
6+
import IPC from './connection/ipc'
7+
import messages from './connection/messages'
8+
import client from './connection/client'
9+
import local from './connection/local'
10+
import terminal from './connection/terminal'
11+
512
export default {
6-
// TODO Fix all of these dynamic requires and circular dependencies
7-
IPC: require('./connection/ipc'),
8-
messages: require('./connection/messages'),
9-
client: require('./connection/client'),
10-
local: require('./connection/local'),
11-
terminal: require('./connection/terminal'),
13+
// TODO remove these from the export default and export them directly (prevents expensive copy)
14+
// TODO don't use this.message use message directly (prevents expensive copy)
15+
IPC: IPC,
16+
messages: messages,
17+
client: client,
18+
local: local,
19+
terminal: terminal,
1220

1321
activate() {
1422
this.messages.activate();

0 commit comments

Comments
 (0)