clean up code, try to make the modal more persisting

Author: aviatesk

lib/julia-client.coffee

@@ -8,9 +8,8 @@ release = require './package/release-note'
 toolbar = require './package/toolbar'
 semver = require 'semver'
 
-# TODO: Update me when tagging a new relase:
+# TODO: Update me when tagging a new relase (and release note)
 INK_VERSION_COMPAT  = "^0.12.3"
-# TODO: Update me when tagging a new relase with a release note
 LATEST_RELEASE_NOTE_VERSION  = "0.12.0"
 
 INK_LINK            = '[`ink`](https://github.com/JunoLab/atom-ink)'

lib/package/release-note.js

@@ -25,18 +25,15 @@ export function activate (startupNoteVersion) {
   view.appendChild(closeButton)
   view.appendChild(inner)
 
-  closeButton.onclick = () => panel.hide()
-
   const showNote = (version, versions) => {
     const p = path.join(RELEASE_NOTE_DIR, version + '.md')
     const markdown = readCode(p)
     inner.innerHTML = marked(markdown)
     panel.show()
     view.focus()
   }
-  const close = () => {
-    panel.hide()
-  }
+  const close = () => panel.hide()
+  closeButton.onclick = close
   const panelView = panel.getElement()
   panelView.style['max-width'] = '75em'
 
@@ -49,19 +46,17 @@ export function activate (startupNoteVersion) {
         .then(version => showNote(version.replace(/v\s(.+)/, '$1')))
         .catch(err => console.log(err))
     }),
-    new Disposable(() => {
-      panel.destroy()
-    }),
     atom.commands.add(panelView, 'julia-client:cancel-release-note',  (event) => {
-      console.log(event);
-      panel.hide()
+      close()
       event.stopPropagation()
+    }),
+    atom.packages.onDidActivateInitialPackages(() => {
+      if (startupNoteVersion) setTimeout(() => showNote(startupNoteVersion), 500)
+    }),
+    new Disposable(() => {
+      panel.destroy()
     })
   )
-
-  if (startupNoteVersion) {
-    setTimeout(() => showNote(startupNoteVersion), 500)
-  }
 }
 
 export function deactivate () {