Skip to content

Commit 333d19b

Browse files
authored
Apply the test overrides in both test and update workflows (#51)
* Apply the test overrides in both test and update workflows * Restore `rm` line
1 parent aa2fde7 commit 333d19b

File tree

3 files changed

+7
-4
lines changed

3 files changed

+7
-4
lines changed

.github/workflows/build.yml

Lines changed: 1 addition & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -115,14 +115,11 @@ jobs:
115115
with:
116116
path: ./lite/dist
117117

118-
# Overwrite some settings to disable cursor blinking,
119-
# which causes inadvertent playwright snapshot failures
120118
- name: Build the JupyterLite app (in test mode)
121119
run: |
122120
cd lite
123121
rm -r dist # jupyter lite will not build in `dist-test/` if `dist/` exists...?
124-
cat jupyter-lite.json | jq '.["jupyter-config-data"].["settingsOverrides"] += {"@jupyterlab/codemirror-extension:plugin":{ "defaultConfig": { "cursorBlinkRate": 0 } } }' > jupyter-lite.json.tmp
125-
mv jupyter-lite.json.tmp jupyter-lite.json
122+
bash ../ui-tests/inject-test-config.sh
126123
jupyter lite build --output-dir dist-test
127124
128125
- name: Upload artifact

.github/workflows/update-integration-tests.yml

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -85,6 +85,7 @@ jobs:
8585
- name: Build the JupyterLite app
8686
run: |
8787
cd lite
88+
bash ../ui-tests/inject-test-config.sh
8889
jupyter lite build --output-dir ../dist
8990
9091
- uses: jupyterlab/maintainer-tools/.github/actions/update-snapshots@v1

ui-tests/inject-test-config.sh

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,5 @@
1+
set -eux
2+
# Overwrite some settings to disable cursor blinking,
3+
# which causes inadvertent playwright snapshot failures
4+
cat jupyter-lite.json | jq '.["jupyter-config-data"].["settingsOverrides"] += {"@jupyterlab/codemirror-extension:plugin":{ "defaultConfig": { "cursorBlinkRate": 0 } } }' > jupyter-lite.json.tmp
5+
mv jupyter-lite.json.tmp jupyter-lite.json

0 commit comments

Comments
 (0)