Skip to content

Commit c0555e1

Browse files
[FIX] Prevent cursor blinking during playwright tests (#48)
* [FIX] Prevent cursor blinking during playwright tests * Remove terminal-extension plugin setting; it's not needed here
1 parent 0f51a29 commit c0555e1

File tree

1 file changed

+21
-2
lines changed

1 file changed

+21
-2
lines changed

.github/workflows/build.yml

Lines changed: 21 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -79,10 +79,12 @@ jobs:
7979
steps:
8080
- name: Checkout
8181
uses: actions/checkout@v4
82+
8283
- name: Setup Python
8384
uses: actions/setup-python@v5
8485
with:
8586
python-version: '3.11'
87+
8688
- uses: actions/download-artifact@v4
8789
with:
8890
name: extension-artifacts
@@ -113,6 +115,23 @@ jobs:
113115
with:
114116
path: ./lite/dist
115117

118+
# Overwrite some settings to disable cursor blinking,
119+
# which causes inadvertent playwright snapshot failures
120+
- name: Build the JupyterLite app (in test mode)
121+
run: |
122+
cd lite
123+
rm -r dist # jupyter lite will not build in `dist-test/` if `dist/` exists...?
124+
cat jupyter-lite.json | jq '.["jupyter-config-data"].["settingsOverrides"] += {"@jupyterlab/codemirror-extension:plugin":{ "defaultConfig": { "cursorBlinkRate": 0 } } }' > jupyter-lite.json.tmp
125+
mv jupyter-lite.json.tmp jupyter-lite.json
126+
jupyter lite build --output-dir dist-test
127+
128+
- name: Upload artifact
129+
uses: actions/upload-artifact@v4
130+
with:
131+
name: lite-app-test
132+
path: ./lite/dist-test
133+
if-no-files-found: error
134+
116135
- name: Leave instructions for testing
117136
run: |
118137
echo "### JupyterLite App is ready" >> $GITHUB_STEP_SUMMARY
@@ -187,10 +206,10 @@ jobs:
187206
- name: Base Setup
188207
uses: jupyterlab/maintainer-tools/.github/actions/base-setup@v1
189208

190-
- name: Download extension package
209+
- name: Download lite app (test mode)
191210
uses: actions/download-artifact@v4
192211
with:
193-
name: lite-app
212+
name: lite-app-test
194213
path: dist
195214

196215
- name: Install jlpm

0 commit comments

Comments
 (0)