Skip to content

Commit e2ac0cb

Browse files
Bump version to 1.1.2 and work around softprops/action-gh-release's incompatibility with immutable releases (#286)
1 parent 7ed4ec4 commit e2ac0cb

File tree

4 files changed

+18
-11
lines changed

4 files changed

+18
-11
lines changed

.github/workflows/cd.yml

Lines changed: 12 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -1,8 +1,9 @@
11
name: CD
22

33
on:
4-
release:
5-
types: [published]
4+
push:
5+
tags:
6+
- 'v*'
67
schedule:
78
- cron: '0 0 * * 0' # Every Sunday at midnight UTC
89
workflow_dispatch:
@@ -43,7 +44,7 @@ jobs:
4344
name: Package and upload to GitHub Release
4445
runs-on: ubuntu-latest
4546
needs: build-app
46-
if: github.event_name == 'release' && github.event.action == 'published'
47+
if: startsWith(github.ref, 'refs/tags/')
4748
permissions:
4849
# Required to upload artifacts to a GitHub release identifier
4950
contents: write
@@ -81,8 +82,14 @@ jobs:
8182
gh attestation verify "${artifact}" --repo $GH_REPO
8283
done
8384
84-
- name: Publish to GitHub Release
85+
- name: Upload release assets with a draft release
8586
uses: softprops/action-gh-release@51cfd90a6d81cfe329568f851fe2236ab4416d17 # v2.2.0
86-
if: github.event_name == 'release' && github.event.action == 'published'
8787
with:
8888
files: upload/*
89+
draft: true
90+
91+
- name: Publish final release
92+
uses: softprops/action-gh-release@51cfd90a6d81cfe329568f851fe2236ab4416d17 # v2.2.0
93+
with:
94+
generate_release_notes: true
95+
draft: false

RELEASE.md

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -7,12 +7,12 @@ We release the extension bundled with the full JupyterLite application files as
77

88
```bash
99
git tag -s vX.Y.Z -m "Release vX.Y.Z"
10-
git push vX.Y.Z
10+
git push origin vX.Y.Z # set the remote name and branch as appropriate, if contributing from a fork or other remote
1111
```
1212

13-
3. Create a new release on GitHub, using the tag created in the previous step. This will trigger the `.github/workflows/cd.yml`
14-
workflow, which will build the extension, install it, install JupyterLite, build the JupyterLite static assets, and create
15-
a tarball with the resulting files. The tarball will be attached to the GitHub Release.
13+
3. The push will trigger the `.github/workflows/cd.yml` workflow, which will build the extension, install it, install JupyterLite,
14+
build the JupyterLite static assets, and create a tarball with the resulting files. The tarball will be attached to a draft
15+
GitHub Release. The workflow will then publish the release automatically.
1616

1717
4. You may verify that the attached tarball contains the expected files, and proceed to deploy it with the sharing service
1818
in [the `jupytereverywhere/infrastructure` repository](https://github.com/JupyterEverywhere/infrastructure).

package.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
{
22
"name": "jupytereverywhere",
3-
"version": "1.1.1",
3+
"version": "1.1.2",
44
"description": "A Jupyter extension for k12 education",
55
"keywords": [
66
"jupyter",

ui-tests/package.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
{
22
"name": "jupytereverywhere-ui-tests",
3-
"version": "1.1.1",
3+
"version": "1.1.2",
44
"description": "Jupyter Everywhere Integration Tests",
55
"private": true,
66
"scripts": {

0 commit comments

Comments
 (0)