Commit 91a21e8
committed
Do not delete keys file if no entries are found
This is follow-up to #3545
It's assumed that if user drops keys file into ASF's config directory, their intention is to make use of that file in order to add something into ASF. While we filter it out and accept the fact that the file may not represent 1:1 ASF's required input, there should be at least one valid entry to assume that user knows what they're doing.
Therefore, deleting the file outright is probably not a good idea, now that we have logging, it's better to leave file as-is and allow user to correct it. Of course, one could also argue that such correction is impossible if 1+ valid entries are found, but that's no longer our concern, user is expected to drop valid file there to begin with, and we're only adding logic for the most obvious kind of mistake, not all mistakes possible.1 parent 355f053 commit 91a21e8
1 file changed
+13
-9
lines changed| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
1490 | 1490 | | |
1491 | 1491 | | |
1492 | 1492 | | |
1493 | | - | |
1494 | | - | |
1495 | | - | |
1496 | | - | |
1497 | | - | |
1498 | | - | |
1499 | | - | |
1500 | | - | |
1501 | | - | |
| 1493 | + | |
1502 | 1494 | | |
| 1495 | + | |
| 1496 | + | |
1503 | 1497 | | |
1504 | 1498 | | |
| 1499 | + | |
| 1500 | + | |
| 1501 | + | |
| 1502 | + | |
| 1503 | + | |
| 1504 | + | |
| 1505 | + | |
| 1506 | + | |
| 1507 | + | |
| 1508 | + | |
1505 | 1509 | | |
1506 | 1510 | | |
1507 | 1511 | | |
| |||
0 commit comments