Sort imports, simplify errors, require Python >= 3.6.

Author: JustinTArthur

ddbcereal/__init__.py

@@ -13,9 +13,9 @@
 #  limitations under the License.
 
 from ddbcereal.deserializing import Deserializer
+from ddbcereal.exceptions import NumberInexact
 from ddbcereal.serializing import Serializer
 from ddbcereal.types import DateFormat, DynamoDBType, PythonNumber
-from ddbcereal.exceptions import NumberInexact
 
 VERSION = 1, 0, 0
 

ddbcereal/deserializing.py

@@ -13,10 +13,12 @@
 #  limitations under the License.
 
 from collections.abc import Set
+from decimal import Decimal
 from fractions import Fraction
-from typing import Any, Mapping, Union, ByteString, MutableMapping, Callable, Sequence
+from typing import (Any, ByteString, Callable, Mapping, MutableMapping,
+                    Sequence, Union)
 
-from decimal import Decimal
+from ddbcereal import NumberInexact
 from ddbcereal.types import PythonNumber
 
 DynamoDBTypeSymbol = str  # Literal['B', 'BOOL', 'BS', 'N', 'NS', 'S', 'SS', 'L', 'M', 'NULL']
@@ -108,7 +110,10 @@ def deserialize_number_as_decimal(
 
 
 def deserialize_number_as_exact_int(serial_value: DynamoDBSerialValue) -> int:
-    return int(serial_value)
+    try:
+        return int(serial_value)
+    except ValueError:
+        raise NumberInexact("Can't be represented exactly as an int.")
 
 
 def deserialize_number_as_int(serial_value: DynamoDBSerialValue) -> int:

ddbcereal/dispatching.py

@@ -1,4 +1,4 @@
-from typing import MutableMapping, Callable
+from typing import Callable, MutableMapping
 
 
 class TypedDispatchTable:

ddbcereal/exceptions.py

@@ -1,16 +1,8 @@
-class NumberRepresentationError(ValueError):
+class NumberInexact(ValueError):
     pass
 
 
-class NumberInexact(NumberRepresentationError):
-    pass
-
-
-class NumberRounded(NumberRepresentationError):
-    pass
-
-
-class NumberNotAllowed(NumberRepresentationError):
+class NumberNotAllowed(ValueError):
     pass
 
 

ddbcereal/serializing.py

@@ -17,10 +17,11 @@
 from collections.abc import Set
 from datetime import datetime
 from fractions import Fraction
-from typing import Any, Mapping, Union, MutableMapping, Callable
+from typing import Any, Callable, Mapping, MutableMapping, Union
 
-from ddbcereal.exceptions import NumberInexact, NumberNotAllowed, StringNotAllowed
-from ddbcereal.types import DynamoDBType, DateFormat
+from ddbcereal.exceptions import (NumberInexact, NumberNotAllowed,
+                                  StringNotAllowed)
+from ddbcereal.types import DateFormat, DynamoDBType
 
 DynamoDBSerializable = Any
 DynamoDBDeserializable = Mapping[str, Any]

docs/conf.py

@@ -7,6 +7,7 @@
 # -- Path setup --------------------------------------------------------------
 import os
 import sys
+
 sys.path.append(os.path.abspath('..'))
 
 

setup.cfg

@@ -18,6 +18,7 @@ license_files =
 
 [options]
 packages = ddbcereal
+python_requires = >=3.6
 
 [options.package_data]
 ddbcereal = py.typed

tests/test_deserializing.py

@@ -5,7 +5,6 @@
 
 from ddbcereal.deserializing import Deserializer, PythonNumber
 
-
 NUM_SMALL_INT = {'N': '42'}
 NUM_SMALL_NEG_INT = {'N': '-42'}
 NUM_NTSC_FILM_APPROX = {'N': '23.976023976023976023976023976023976024'}