great bug fixes and test additions by @Roger-luo

Author: Jutho

src/TupleTools.jl

@@ -216,7 +216,7 @@ end
 Returns the value and index of the maximum element in a tuple. If there are multiple
 maximal elements, then the first one will be returned.
 """
-findmax(::Tuple{Any}) = (t[1], 1)
+findmax(t::Tuple{Any}) = (t[1], 1)
 findmax(t::Tuple) = _findmax(tail(t),2,t[1],1)
 _findmax(t::Tuple{}, s, v, i) = (v, i)
 @inline function _findmax(t::Tuple, s, v, i)

test/runtests.jl

@@ -10,14 +10,18 @@ ip = invperm(p)
 
 t = (p...,)
 
+@test @inferred(TupleTools.argtail2(1, 2, 3, 4)) == (3, 4)
 @test @inferred(TupleTools.tail2(t)) == t[3:n]
 @test @inferred(TupleTools.unsafe_tail(t)) == t[2:n]
 @test @inferred(TupleTools.unsafe_front(t)) == t[1:n-1]
 @test @inferred(TupleTools.unsafe_tail(())) == ()
 @test @inferred(TupleTools.unsafe_front(())) == ()
-
+@test @inferred(TupleTools.vcat()) == ()
+@test @inferred(TupleTools.vcat((1, 2))) == (1, 2)
+@test @inferred(TupleTools.getindices(t, ())) == ()
 @test @inferred(TupleTools.getindices(t, (1,2,3))) == t[1:3]
 
+@test @inferred(TupleTools.deleteat((1, 2), (1, ))) == (2, )
 for i = 1:n
     @test @inferred(TupleTools.deleteat(t, i)) == (deleteat!(copy(p), i)...,)
     @test @inferred(TupleTools.insertat(t, i, (1,2,3))) == (vcat(p[1:i-1], [1,2,3], p[i+1:n])...,)
@@ -28,23 +32,40 @@ for i = 0:n
 end
 @test @inferred(TupleTools.vcat((1,2,3),4,(5,),(),(6,7,8))) == (1,2,3,4,5,6,7,8)
 
+@test @inferred(TupleTools.sum(())) == 0
+@test @inferred(TupleTools.sum((1, ))) == 1
 @test @inferred(TupleTools.sum(t)) == sum(t)
+@test @inferred(TupleTools.cumsum(())) == ()
+@test @inferred(TupleTools.cumsum((1, ))) == (1, )
 @test @inferred(TupleTools.cumsum(t)) == (cumsum(p)...,)
+@test @inferred(TupleTools.prod(())) == 1
+@test @inferred(TupleTools.prod((2, ))) == 2
 @test @inferred(TupleTools.prod(t)) == prod(t)
+@test @inferred(TupleTools.cumprod(())) == ()
+@test @inferred(TupleTools.cumprod((1, ))) == (1, )
 @test @inferred(TupleTools.cumprod(t)) == (cumprod(p)...,)
 
-@test @inferred(TupleTools.findmin(t)) == findmin(t)
-@test @inferred(TupleTools.findmax(t)) == findmax(t)
-@test @inferred(TupleTools.minimum(t)) == minimum(t)
-@test @inferred(TupleTools.maximum(t)) == maximum(t)
-@test @inferred(TupleTools.argmin(t)) == argmin(t)
-@test @inferred(TupleTools.argmax(t)) == argmax(t)
+for a in (t, (1, ))
+    @test @inferred(TupleTools.findmin(a)) == findmin(a)
+    @test @inferred(TupleTools.findmax(a)) == findmax(a)
+    @test @inferred(TupleTools.minimum(a)) == minimum(a)
+    @test @inferred(TupleTools.maximum(a)) == maximum(a)
+    @test @inferred(TupleTools.argmin(a)) == argmin(a)
+    @test @inferred(TupleTools.argmax(a)) == argmax(a)
+end
 
+@test @inferred(TupleTools.sort((1, ))) == (1, )
+@test @inferred(TupleTools.sort(())) == ()
 @test @inferred(TupleTools.sort(t; rev = true)) == (sort(p; rev = true)...,)
+@test @inferred(TupleTools.sort(t; rev = false)) == (sort(p; rev = false)..., )
 @test @inferred(TupleTools.sortperm(t)) == (sortperm(p)...,)
+@test @inferred(TupleTools.sortperm(t; rev=true)) == (sortperm(p; rev=true)..., )
 @test @inferred(TupleTools.invperm(t)) == (ip...,)
 @test @inferred(TupleTools.isperm(t)) == true
 @test @inferred(TupleTools.isperm((1,2,1))) == false
 @test @inferred(TupleTools.permute(t, t)) == (p[p]...,)
 
+@test @inferred(TupleTools.vcat()) == ()
+@test @inferred(TupleTools.diff(())) == ()
+@test @inferred(TupleTools.diff((1, ))) == ()
 @test @inferred(TupleTools.diff((1, 2, 3))) == (1, 1)