C TypeTreeHelper - Safeguard against bogus Array definition (#300)

mos9527 · web-flow · commit ddf47a64397e · 2025-02-13T13:59:58.000+01:00
* C TypeTreeHelper - Safeguard against bogus Array definition
diff --git a/UnityPyBoost/TypeTreeHelper.cpp b/UnityPyBoost/TypeTreeHelper.cpp
@@ -834,6 +834,12 @@ PyObject *read_typetree_value(ReaderT *reader, TypeTreeNodeObject *node, TypeTre
         if (child && child->_data_type == NodeDataType::Array)
         {
             // array
+            if (PyList_GET_SIZE(child->m_Children) != 2)
+            {
+                PyErr_SetString(PyExc_ValueError, "Array node must have 2 children");
+                return NULL;
+            }
+
             if (child->_align)
             {
                 align = true;

Original file line number	Diff line number	Diff line change
`@@ -834,6 +834,12 @@ PyObject read_typetree_value(ReaderT reader, TypeTreeNodeObject *node, TypeTre`
`834`	`834`	`if (child && child->_data_type == NodeDataType::Array)`
`835`	`835`	`{`
`836`	`836`	`// array`
	`837`	`+ if (PyList_GET_SIZE(child->m_Children) != 2)`
	`838`	`+ {`
	`839`	`+ PyErr_SetString(PyExc_ValueError, "Array node must have 2 children");`
	`840`	`+ return NULL;`
	`841`	`+ }`
	`842`	`+`
`837`	`843`	`if (child->_align)`
`838`	`844`	`{`
`839`	`845`	`align = true;`