Flush API change.

Signed-off-by: Kevin Baichoo <envoy@kevinbaichoo.com>

Author: KBaichoo

api/envoy/config/core/v3/protocol.proto

@@ -663,10 +663,11 @@ message Http2ProtocolOptions {
   // Configure the maximum amount of metadata than can be handled per stream. Defaults to 1 MB.
   google.protobuf.UInt64Value max_metadata_size = 17;
 
-  // Disables encoding the headers using huffman encoding.
+  // Controls whether to encode headers using huffman encoding.
   // This can be useful in cases where the cpu spent encoding the headers isn't
   // worth the network bandwidth saved e.g. for localhost.
-  bool disable_huffman_encoding = 18;
+  // If unset, uses the data plane's default value.
+  google.protobuf.BoolValue enable_huffman_encoding = 18;
 }
 
 // [#not-implemented-hide:]

source/common/http/http2/codec_impl.cc

@@ -2082,7 +2082,7 @@ ConnectionImpl::Http2Options::Http2Options(
   og_options_.max_header_field_size = max_headers_kb * 1024;
   og_options_.allow_extended_connect = http2_options.allow_connect();
   og_options_.allow_different_host_and_authority = true;
-  if (http2_options.disable_huffman_encoding()) {
+  if (!PROTOBUF_GET_WRAPPED_OR_DEFAULT(http2_options, enable_huffman_encoding, true)) {
     if (http2_options.has_hpack_table_size() && http2_options.hpack_table_size().value() == 0) {
       og_options_.compression_option = http2::adapter::OgHttp2Session::Options::DISABLE_COMPRESSION;
     } else {
@@ -2119,7 +2119,7 @@ ConnectionImpl::Http2Options::Http2Options(
                                                       http2_options.hpack_table_size().value());
   }
 
-  if (http2_options.disable_huffman_encoding()) {
+  if (!PROTOBUF_GET_WRAPPED_OR_DEFAULT(http2_options, enable_huffman_encoding, true)) {
     nghttp2_option_set_disable_huffman_encoding(options_, 1);
   }
 

test/common/http/http2/codec_impl_test.cc

@@ -3188,7 +3188,7 @@ TEST_P(Http2CodecImplTest, TestCanDisableHuffmanEncoding) {
   request_headers.addCopy("x-well-compressable-header", std::string(1000, 'a'));
 
   // Create a connection with huffman disabled.
-  client_http2_options_.set_disable_huffman_encoding(true);
+  client_http2_options_.mutable_enable_huffman_encoding()->set_value(false);
   initialize();
 
   std::string buffer_without_huffman;
@@ -3206,7 +3206,7 @@ TEST_P(Http2CodecImplTest, TestCanDisableHuffmanEncoding) {
   ASSERT_EQ(server_wrapper_->buffer_.length(), 0);
 
   // Create a connection with huffman enabled.
-  client_http2_options_.set_disable_huffman_encoding(false);
+  client_http2_options_.mutable_enable_huffman_encoding()->set_value(true);
   NiceMock<Network::MockConnection> client_connection2;
   MockConnectionCallbacks client_callbacks2;
   client_ = std::make_unique<TestClientConnectionImpl>(