Skip to content

Commit 1b04e04

Browse files
MiKomseanharmer
authored andcommitted
Use patched FakeIt
The upstream version is not compatible with Clang >=19 so it breaks macOS builds on latest agents. Added readme that describes what's the deal. fakeit.hpp has to be added to .codespellrc explicitly because codespell actually can't properly ignore folders from .codespellrc when called from pre-commit. See codespell-project/codespell#3196
1 parent 9d617c3 commit 1b04e04

File tree

7 files changed

+10175
-10
lines changed

7 files changed

+10175
-10
lines changed

.codespellrc

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,5 @@
11
[codespell]
2-
skip = ./build-*,.git
2+
skip = ./build*,.git,*fakeit.hpp
33
interactive = 3
44
#ignore camelCase, regardless. also mixed case words with correct spelling
55
ignore-regex = \b([a-z]+[A-Z0-9][a-z0-9]*|te|fo)\b

3rdparty/.clang-format

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1 @@
1+
DisableFormat: true

3rdparty/fakeit/README.md

Lines changed: 18 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,18 @@
1+
# FakeIt
2+
3+
FakeIt 2.4.1 (from <https://raw.githubusercontent.com/eranpeer/FakeIt/refs/tags/2.4.1/single_header/doctest/fakeit.hpp>)
4+
with a fix for stricter compilation on Clang >=19.
5+
6+
Line 7924 changed from:
7+
8+
```cpp
9+
ParamWalker<N - 1>::template Assign(arg_vals, std::forward<arglist>(args)...);
10+
```
11+
12+
```cpp
13+
ParamWalker<N - 1>::Assign(arg_vals, std::forward<arglist>(args)...);
14+
```
15+
16+
See <https://github.com/eranpeer/FakeIt/issues/348>
17+
18+
After FakeIt 2.5.0 is released we can go back to using the vanilla version.

0 commit comments

Comments
 (0)